Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found several plan show locus NULL when explain(locus).
And a assertion added after plan created show more like that.
There are caused by different reasons, this pr fix all.
Reproduce:
Locus: NULL
Fix materialize locus is null when enable_material is off. When creating plan, make_material() is added directly besides a material path and lacks of locus info.
Add locus info for that material plan.
Fix locus is null under Subplan.
fix_subplan_motion() will add Motion by Flow, either Gather or Broadcast. Add locus according to Flow type.
Fix Result, One-Time Filter Result locus is null.
Result node will call create_scan_plan() itself if it's a simple RTE_RESULT base relation. Add locus for that.
Fix PREPARE EXECUTE statement locus null.
Plancache will copy PlannedStmt list if it's not a oneshot plan. Add files locustype and parallel in CopyPlanFields().
Authored-by: Zhang Mingli avamingli@gmail.com
closes: #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel