Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test artifact upload path incorrectly #240

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Baowen648
Copy link
Contributor

In order to make it easier for users to quickly locate error logs, we have copied the entire directory to a fixed location and thoroughly tested it without encountering any issues.

closes: #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready🥳

@Baowen648
Copy link
Contributor Author

The commit information has been completed. I'll be happy to help you check if there are any further changes needed. @tuhaihe

@tuhaihe
Copy link
Member

tuhaihe commented Oct 17, 2023

Hey @Zhangbaowen-Hashdata: I appreciate your effort, but the maximum limit for the commit body length is 72 characters instead of 50. Could you amend it again?

In order to make it easier for users to quickly error logs, we have
copied the entire directory to a fixed location and thoroughly tested
it without encountering any issues.
@baotingfang baotingfang requested a review from tuhaihe October 17, 2023 07:51
@Baowen648 Baowen648 force-pushed the zbw-correct-commit_1017 branch from 3e3afb6 to c691eef Compare October 17, 2023 07:53
Copy link
Contributor

@baotingfang baotingfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tuhaihe tuhaihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
After this PR is merged, we can close #118.

Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit 0902ea7 into apache:main Oct 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants