Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: support debug workflow #275

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Enhancement: support debug workflow #275

merged 1 commit into from
Nov 3, 2023

Conversation

smartyhero
Copy link
Contributor

When the workflow fails to run, the execution will be blocked. Developers can find the ssh command to log in to the runner machine in the workflow running log. This is convenient for developers to debug.


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

It is convenient for developers to debug when the workflow fails to run.

Does this PR introduce any user-facing change?

When the workflow fails to run, developers can log into the machine to debug

How was this patch tested?

none

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready🥳

When the workflow fails to run, the execution will be blocked.
Developers can find the ssh command to log in to the runner machine
in the workflow running log. This is convenient for developers to debug.
@baotingfang baotingfang requested a review from tuhaihe November 2, 2023 02:27
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit aabdd27 into apache:main Nov 3, 2023
9 checks passed
@smartyhero smartyhero deleted the cicd/support_debug branch November 22, 2023 02:33
baotingfang pushed a commit that referenced this pull request Dec 1, 2023
When the workflow fails to run, the execution will be blocked.
Developers can find the ssh command to log in to the runner machine
in the workflow running log. This is convenient for developers to debug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants