Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Answer Query Using Materialized Views] Refactor codes to new file aqumv.c #321

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

avamingli
Copy link
Contributor

@avamingli avamingli commented Dec 4, 2023

Refactor to external func answer_query_using_materialized_views() with some refinements.
Rename GUC to enable_answer_query_using_materialized_views to avoid duplicated name with implementation function.
New function aqumv_init_context() to init context of rewrite.

Authored-by: Zhang Mingli avamingli@gmail.com

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@avamingli avamingli self-assigned this Dec 4, 2023
@avamingli avamingli requested a review from yjhjstz December 4, 2023 12:01
@avamingli avamingli force-pushed the refactor_codes_to_aqumv branch from d289001 to baa1a66 Compare December 4, 2023 14:09
@avamingli avamingli force-pushed the refactor_codes_to_aqumv branch from baa1a66 to 20b294f Compare December 5, 2023 01:35
Refactor to external func answer_query_using_materialized_views
with some refinements.
Rename GUC to enable_answer_query_using_materialized_views to
avoid duplicated name with implementation function.
New function aqumv_init_context() to init context of rewrite.

Authored-by: Zhang Mingli avamingli@gmail.com
@avamingli avamingli force-pushed the refactor_codes_to_aqumv branch from 20b294f to c1dd6c9 Compare December 5, 2023 01:42
Copy link
Member

@yjhjstz yjhjstz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avamingli avamingli merged commit 5a663d7 into apache:main Dec 5, 2023
9 checks passed
@avamingli avamingli deleted the refactor_codes_to_aqumv branch December 5, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants