Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the table AM: scan_begin_extractcolumns to contain execution context #329

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Refactor the table AM: scan_begin_extractcolumns to contain execution context #329

merged 1 commit into from
Dec 12, 2023

Conversation

gfphoenix78
Copy link
Contributor

Refactor the signature of scan_begin_extractcolumns to contain execution context, so that the scan node is able to filter data by evaluating expressions in low level. Low-level filter may have less cost than extracting all columns in a row and filtered out by the upper execution node.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

my-ship-it
my-ship-it approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it
Refactor the table AM: scan_begin_extractcolumns to contain execution…
edd7bf6 
… context

Refactor the signature of scan_begin_extractcolumns to contain execution
context, so that the scan node is able to filter data by evaluating
expressions in low level. Low-level filter may have less cost than extracting
all columns in a row and filtered out by the upper execution node.
@my-ship-it my-ship-it merged commit 1a6372e into apache:main Dec 12, 2023
9 checks passed
@gfphoenix78 gfphoenix78 deleted the refactor-tam branch December 15, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@my-ship-it my-ship-it my-ship-it approved these changes

@avamingli avamingli Awaiting requested review from avamingli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfphoenix78 @my-ship-it