Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move struct workfile_set to workfile_mgr.c #331

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Move struct workfile_set to workfile_mgr.c #331

merged 1 commit into from
Dec 14, 2023

Conversation

gfphoenix78
Copy link
Contributor

The struct workfile_set has a field named operator, which conflicts with C++ key words when its header workfile_mgr.h is included in C++ code.
Luckily, it has no need to expose in the header file. We just keep the type declaration in the header file, but define the structure in the C source code.

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

my-ship-it
my-ship-it approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfphoenix78 @my-ship-it
Move struct workfile_set to workfile_mgr.c
10f8a77 
The struct workfile_set has a field named `operator`, which conflicts
with C++ key words when its header workfile_mgr.h is included in C++
code.
Luckily, it has no need to expose in the header file. We just keep
the type declaration in the header file, but define the structure
in the C source code.
@my-ship-it my-ship-it merged commit 32d6446 into apache:main Dec 14, 2023
9 checks passed
@gfphoenix78 gfphoenix78 deleted the workset branch December 15, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@my-ship-it my-ship-it my-ship-it approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfphoenix78 @my-ship-it