Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace pg_ext_aux for extension #333

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

gfphoenix78
Copy link
Contributor

New table access method(TAM) may have their own internal auxiliary tables, like AO tables have the visimap table, aoseg files, block directory tables. The auxiliary tale is not real user data. It's used to maintain the data structure of the new TAM. The auxiliary table should be protected by the system, or modifying the auxiliary table, by the user, will corrupt the user table.

This namespace mainly allows the extensions to have their internal auxiliary tables and protects them. The namespace of the auxiliary tables is not allowed to change, at least it's not necessary at the moment.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2023

CLA assistant check
All committers have signed the CLA.

@gfphoenix78 gfphoenix78 force-pushed the pg_ext_aux branch 3 times, most recently from 7990f25 to 3c6ed48 Compare December 12, 2023 09:10
New table access method(TAM) may have their own internal auxiliary
tables, like AO tables have the visimap table, aoseg files, block
directory tables. The auxiliary tale is not real user data. It's
used to maintain the data structure of the new TAM. The auxiliary table
should be protected by the system, or modifying the auxiliary table,
by the user, will corrupt the user table.

This namespace mainly allows the extensions to have their internal
auxiliary tables and protects them. The namespace of the auxiliary
tables is not allowed to change, at least it's not necessary at the
moment.
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfphoenix78 gfphoenix78 merged commit a9889d1 into apache:main Dec 14, 2023
9 checks passed
@gfphoenix78 gfphoenix78 deleted the pg_ext_aux branch December 15, 2023 12:20
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Jul 8, 2024
New table access method(TAM) may have their own internal auxiliary
tables, like AO tables have the visimap table, aoseg files, block
directory tables. The auxiliary tale is not real user data. It's
used to maintain the data structure of the new TAM. The auxiliary table
should be protected by the system, or modifying the auxiliary table,
by the user, will corrupt the user table.

This namespace mainly allows the extensions to have their internal
auxiliary tables and protects them. The namespace of the auxiliary
tables is not allowed to change, at least it's not necessary at the
moment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants