Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom object class support #335

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Add custom object class support #335

merged 1 commit into from
Dec 15, 2023

Conversation

gfphoenix78
Copy link
Contributor

Extension may have some database objects that need to exist/delete consistently. We might use dependencies to record these relation-ship and remove them consistently and clearly.

More generally, this patch allows extensions to create their own auxiliary relations like system catalog in schema pg_ext_aux. The auxiliary relations can't exist alone and have their own dynamic oclass and callbacks to implement, including do_delete.

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

Extension may have some database objects that need to exist/delete
consistently. We might use dependencies to record these relation-ship
and remove them consistently and clearly.

More generally, this patch allows extensions to create their own
auxiliary relations like system catalog in schema `pg_ext_aux`.
The auxiliary relations can't exist alone and have their own
dynamic oclass and callbacks to implement, including do_delete.
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit ce30a6a into apache:main Dec 15, 2023
9 checks passed
@gfphoenix78 gfphoenix78 deleted the coc branch December 15, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants