Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues about namespace pg_ext_aux #340

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

gfphoenix78
Copy link
Contributor

Namespace pg_ext_aux is different from the normal namespace created by the user. It's only used internally. The user isn't allowed to create table in pg_ext_aux explicitly.

For temp table, the namespace of the auxiliary table is also pg_ext_aux, not a temp namespace. It seems complicated to distinguish pg_ext_aux and pg_ext_aux_temp. The temp table will be automatically dropped when either the table is dropped or the session is closed. The internal auxiliary relation depends on the table will also automatically dropped if its table is dropped.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

Namespace pg_ext_aux is different from the normal namespace
created by the user. It's only used internally. The user
isn't allowed to create table in pg_ext_aux explicitly.

For temp table, the namespace of the auxiliary table is also
pg_ext_aux, not a temp namespace. It seems complicated to
distinguish pg_ext_aux and pg_ext_aux_temp. The temp table will
be automatically dropped when either the table is dropped or
the session is closed. The internal auxiliary relation depends
on the table will also automatically dropped if its table is
dropped.
Copy link
Contributor

@avamingli avamingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gfphoenix78 gfphoenix78 merged commit 70b9d2c into apache:main Dec 18, 2023
9 checks passed
@gfphoenix78 gfphoenix78 deleted the fix-extaux branch December 18, 2023 12:08
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Jul 8, 2024
Namespace pg_ext_aux is different from the normal namespace
created by the user. It's only used internally. The user
isn't allowed to create table in pg_ext_aux explicitly.

For temp table, the namespace of the auxiliary table is also
pg_ext_aux, not a temp namespace. It seems complicated to
distinguish pg_ext_aux and pg_ext_aux_temp. The temp table will
be automatically dropped when either the table is dropped or
the session is closed. The internal auxiliary relation depends
on the table will also automatically dropped if its table is
dropped.

Reviewed-by: Zhang Mingli <avamingli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants