Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CREATE TYPE in namespace pg_ext_aux #380

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Fix CREATE TYPE in namespace pg_ext_aux #380

merged 2 commits into from
Feb 20, 2024

Conversation

gfphoenix78
Copy link
Contributor

Creating relation in namespace pg_ext_aux will not create the array type. The relations in pg_ext_aux are considered as auxiliary tables, used by some extensions. While creating type is different, the new type will also have its array type like other normal types.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@gfphoenix78
Copy link
Contributor Author

No test. Creating type in namespace pg_ext_aux will only be used by some extensions. Normal test cases don't cover it.

@gfphoenix78
Fix CREATE TYPE in namespace pg_ext_aux
90aa7ea 
Creating relation in namespace pg_ext_aux will not create the array
type. The relations in pg_ext_aux are considered as auxiliary tables,
used by some extensions. While creating type is different, the new
type will also have its array type like other normal types.
@gfphoenix78
Add test in greenplum_schedule
a5bd1b3
my-ship-it
my-ship-it approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit d364a23 into apache:main Feb 20, 2024
9 checks passed
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Jul 8, 2024
@gfphoenix78
Fix CREATE TYPE in namespace pg_ext_aux (apache#380)
4debc33 
Creating relation in namespace pg_ext_aux will not create the array type. The relations under
pg_ext_aux are considered as auxiliary tables, and used by some extensions. While creating type
is different, the new type will also have its array type like other normal types, which follows behavior
of pg_catalog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@my-ship-it my-ship-it my-ship-it approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfphoenix78 @my-ship-it