Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move preloaded interconnect to the header file #388

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Move preloaded interconnect to the header file #388

merged 1 commit into from
Mar 13, 2024

Conversation

gfphoenix78
Copy link
Contributor

interconnect is expected to preload if the macro option ENABLE_PRELOAD_IC_MODULE is set. The header file
process_shared_preload_libraries.h is kept to save all builtin shared preloaded libraries.

This commit defines the interconnect preload in
process_shared_preload_libraries.h to minimize code diverge.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@gfphoenix78
Move preloaded interconnect to the header file
598fe03 
`interconnect` is expected to preload if the macro option
ENABLE_PRELOAD_IC_MODULE is set. The header file
`process_shared_preload_libraries.h` is kept to save all
builtin shared preloaded libraries.

This commit defines the `interconnect` preload in
`process_shared_preload_libraries.h` to minimize code
diverge.
@gfphoenix78 gfphoenix78 requested a review from jiaqizho March 4, 2024 05:02
my-ship-it
my-ship-it approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jiaqizho
jiaqizho approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jiaqizho jiaqizho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit dcbb652 into apache:main Mar 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@my-ship-it my-ship-it my-ship-it approved these changes

@jiaqizho jiaqizho jiaqizho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gfphoenix78 @jiaqizho @my-ship-it