PendingDelete: expand the pending deletes interface #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaqizho
changed the title
jiaqizho
force-pushed
the
expand-pending-delete-interface
branch
from
19c14b6 to
e545a96
Compare
jiaqizho
force-pushed
the
expand-pending-delete-interface
branch
from
e545a96 to
626c3ff
Compare
jiaqizho
changed the title
my-ship-it
approved these changes
May 22, 2024
my-ship-it
reviewed
May 22, 2024
wenchaozhang-123
approved these changes
May 23, 2024
my-ship-it
approved these changes
May 24, 2024
foreyes
pushed a commit
to foreyes/cloudberrydb
that referenced
this pull request
Jul 8, 2024
The pending deletes in CBDB can only mount the relfilenode. Current change expand the pending deletes interface, make self-defined structure can be mount in the pending delete list, also can use the self-defined callback decide how to delete the resource. It's very helper for the UFile or other extension which will use the different local/remote resource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change logs
The pending deletes in CBDB can only mount the
relfilenode.Current change expand the pending deletes interface, make self-defined structure can be mount in the pending delete list, also can use the self-defined callback decide how to delete the resource. It's very helper for the
UFileor other extension which will use the different local/remote resource.Why are the changes needed?
expand the pending delete
Does this PR introduce any user-facing change?
nope
How was this patch tested?
none
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallelcloudberrydb/devteam for review and approval when your PR is ready🥳