Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Answer Query Using Materialized Views] Support LIMIT/OFFSET/FETCH clause on origin query. #446

Merged
merged 1 commit into from
May 27, 2024

Conversation

avamingli
Copy link
Contributor

@avamingli avamingli commented May 23, 2024

If origin query has LIMIT clause, we could process it on view query.
We could process FETCH too as ORDER BY is supported on origin query.

create incremental materialized view mv as
  select c1 as mc1, c2 as mc2, c3 as mc3, c4 as mc4
  from t1 where c1 > 90;

Origin querys:

  select c2 from t1 where c1 > 90 limit 3 offset 4;
  select c2 from t1 where c1 > 90 order by c3, c4
    fetch first 3 rows with ties;

Could be rewritten to:

  select mc2 from mv order by mc1 limit 3 offset 4;
  select mc2 from mv order by mc3, mc4
    fetch first 3 rows with ties;

See more cases in tests.

Authored-by: Zhang Mingli avamingli@gmail.com

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

If origin query has LIMIT clause, we could process it on
view query.
We could process FETCH too as ORDER BY is supported on
origin query.

create incremental materialized view mv as
  select c1 as mc1, c2 as mc2, c3 as mc3, c4 as mc4
  from t1 where c1 > 90;

Origin querys:

  select c2 from t1 where c1 > 90 limit 3 offset 4;
  select c2 from t1 where c1 > 90 order by c3, c4
    fetch first 3 rows with ties;

Could be rewritten to:

  select mc2 from mv order by mc1 limit 3 offset 4;
  select mc2 from mv order by mc3, mc4
    fetch first 3 rows with ties;

Authored-by: Zhang Mingli avamingli@gmail.com
@avamingli avamingli requested review from yjhjstz and my-ship-it May 23, 2024 07:20
@avamingli avamingli merged commit 21603eb into apache:main May 27, 2024
10 checks passed
@avamingli avamingli deleted the feature_limit branch May 27, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants