Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AQUMV] Expose the function adjust view query and varno fix. #469

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

avamingli
Copy link
Contributor

Add new function aqumv_adjust_simple_query.
Make it external for other codes may use the same logic. It has two main functions:
Adjust view query, remove 'old' and 'new' rte for refresh, make it to be a valid query tree.
Fix varno after that rewrite.

Fix varnosyn, keep it with varno as we don't have syntactic one.

Authored-by: Zhang Mingli avamingli@gmail.com

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

Add new function aqumv_adjust_simple_query.
Make it external for other codes may use the same logic.
It has two main functions:
Adjust view query, remove 'old' and 'new' rte for refresh, make
it to be a valid query tree.
Fix varno after that rewrite.

Fix varnosyn, keep it with varno as we don't have syntactic one.

Authored-by: Zhang Mingli avamingli@gmail.com
@avamingli avamingli requested review from yjhjstz and my-ship-it June 13, 2024 15:37
@my-ship-it my-ship-it merged commit b446160 into apache:main Jun 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants