Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gpinitsystem #490

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Fix gpinitsystem #490

merged 2 commits into from
Jul 8, 2024

Conversation

fanfuxiaoran
Copy link
Contributor

@fanfuxiaoran fanfuxiaoran commented Jul 1, 2024

  • check if it is external fts in some places
  • remove 'guc gp_cbdb_deploy' ( it is not used any more)

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@fanfuxiaoran fanfuxiaoran requested a review from jiaqizho July 1, 2024 07:08
@jiaqizho
Copy link
Contributor

jiaqizho commented Jul 2, 2024

hi @fanfuxiaoran,

Sorry, I just remembered, this GUC value is provided to the k8s team.

double checked with k8s team, we can direct remove the GUC gp_cbdb_deploy safely.

check if is is_external_fts in some places
Copy link
Contributor

@jiaqizho jiaqizho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit 4a0af58 into apache:main Jul 8, 2024
10 checks passed
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Sep 20, 2024
* Fix gpinitsystem
   check if is is_external_fts in some places
* Remove guc gp_cbdb_deploy

(cherry picked from commit 4a0af58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants