Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile errors detected by gcc 12 #503

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Fix compile errors detected by gcc 12 #503

merged 3 commits into from
Jul 8, 2024

Conversation

gfphoenix78
Copy link
Contributor

  • Check the string value, not the array itself
  • Use global namespace to eliminate ambiguity
  • Fix assert condition

fix #494

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@gfphoenix78
Fix compile errors detected by gcc 12
7c3dddf 
* Check the string value, not the array itself
* Use global namespace to eliminate ambiguity
* Fix assert condition
@gfphoenix78
Fix assert imply condition
04076d9
@gfphoenix78
comment
da4df9e
@gfphoenix78 gfphoenix78 requested a review from avamingli July 8, 2024 08:17
@gfphoenix78 gfphoenix78 merged commit 7670f82 into apache:main Jul 8, 2024
10 checks passed
@gfphoenix78 gfphoenix78 deleted the fix-gcc12-errors branch July 8, 2024 10:02
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Sep 20, 2024
@gfphoenix78 @fanfuxiaoran
Fix compile errors detected by gcc 12 (apache#503)
7f0fd71 
* Check the string value, not the array itself
* Use global namespace to eliminate ambiguity
* Ignore assert condition.

Reviewed-by: Zhang Mingli avamingli@gmail.com
(cherry picked from commit 7670f82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avamingli avamingli avamingli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Build failed with gcc 12 on openEuler 24.03
2 participants
@gfphoenix78 @avamingli