Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bsearch compare function in guc.c #507

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

gfphoenix78
Copy link
Contributor

The prototype of the bsearch()'s compare function is
int (*compar)(const void *, const void *));

The first argument is expected to the key object,
the second is the array member.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

The prototype of the bsearch()'s compare function is
`int (*compar)(const void *, const void *));`

The first argument is expected to the key object,
the second is the array member.
@gfphoenix78 gfphoenix78 requested a review from avamingli July 9, 2024 06:18
@gfphoenix78 gfphoenix78 merged commit d4decf9 into apache:main Jul 9, 2024
11 checks passed
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Sep 20, 2024
The prototype of the bsearch()'s compare function is
`int (*compar)(const void *, const void *));`

The first argument is expected to the key object,
the second is the array member.

(cherry picked from commit d4decf9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants