-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make gp_dqa test case stable #521
Conversation
…sion of floating-point arithmetic
Why create another pr? |
@avamingli Mingli, thanks for the suggestion. According to it I changed to use extra_float_digits. The old PR was automatically closed when I undo the earlier commit. The modification is totally different from the one earlier. Would it be OK if I use this new PR? |
Next time, could use git reset to rollback your commit, git rebase to squash commits and push force on your branch if ready. |
@avamingli Got it. Will do. Thanks Mingli. |
Unfortunately I forgot to close this PR before another commit. I think it's required to go through the CI process again. |
Hi Mingli @avamingli, |
Pushed. |
ICW test case gp_dqa failed intermittently, as following example:
It is not a good practice to verify the fload8 data directly due to precision issues.
Thus setting GUC extra_float_digits=-1 to truncate the precision of the floating-point number to a manageable level that minimizes the impact of rounding errors. The result of corresponding example would be changed to as following:
This modification ensures that the comparison of floating-point results in our test cases is conducted in a manner that is both practical and reliable.