Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust test cases for the cloudberrydb binary swap test #537

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

congxuebin
Copy link
Contributor

@congxuebin congxuebin commented Jul 28, 2024

Change Summary:

Change 1: introduction of the "system_group" in Binary Swap test
Previously, cloudberrydb introduced a new control group named "system_group" to manage the resource usage of the postmaster process and all other auxiliary processes.

select rsgname, parent from pg_resgroup
  where rsgname not like 'rg_dump_test%'
  order by oid;
    rsgname    | parent 
---------------+--------
 default_group |      0
 admin_group   |      0
 system_group  |      0
(3 rows)

The "system_group" were added to the following three resource group test cases:
resgroup_current_1_queue
resgroup_other_2_queue
resgroup_current_3_queue

Change 2: addressing missing DDL for "insert" test case under Binary Swap test suite

create table if not exists test_table_heap_with_toast (id int, col1 int, col2 text) with (appendonly=false);
create table if not exists test_table_ao_with_toast (id int, col1 int, col2 text) with (appendonly=true, orientation=row);
create table if not exists test_table_co_with_toast (id int, col1 int, col2 text) with (appendonly=true, orientation=column);

Change 3: refinement of Binary Swap test suite scheduling

The "insert" and second occurrence of "pg_dumpall_current" were deemed unnecessary in the "schedule3" because no subsequent pg_dump comparison. Thus the redundant "pg_dumpall_current" has been removed and test case "insert" has been moved to "schedule1"

@my-ship-it
Copy link
Contributor

@congxuebin Please make CI pass

@congxuebin
Copy link
Contributor Author

@Zhangbaowen-Hashdata Hi Baowen, the ICW job was unexpectedly cancelled for an unknown reason. Do you have any idea?

image

@Baowen648
Copy link
Contributor

Yesterday we were upgrading the runner image. The job in progress may be canceled. I can try it again by rerunning it.

@gfphoenix78 gfphoenix78 merged commit 1ce51c5 into apache:main Aug 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants