Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create test cases for upgrading compatibility validation #560

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

congxuebin
Copy link
Contributor

@congxuebin congxuebin commented Aug 7, 2024

To facilitate customer upgrades, it is planned to ensure binary swap compatibility within specific version ranges of cbdb. Therefore, the binary swap test is planned to be enabled.

The primary objective of creating the test cases is to validate that data created in an older version of the database remains accessible and usable after a binary format switch and upgrade. To achieve this, various types of tables and indexes were created, and data was loaded into each table with 10000 records. Data accessibility is then validated through queries and DML operations both before and after the upgrade.

Various types of tables:

Name Type Partition by Storage
sales_ao Table None Append-only
sales_aocs Table None Append-only Columnar
sales_heap Table None Heap
sales_partition_ao Partitioned Range Append-only
sales_partition_aocs Partitioned Hash Append-only Columnar
sales_partition_heap Partitioned List Heap

Each table was populated with 10000 records, covering a variety of data types.

Index Types Used:

  • B-tree
  • Bitmap
  • Unique
  • BRIN (Block Range Index)

Data Validation:

  • A series of queries were designed to access data with and without utilizing the created indexes.
  • Bulk INSERT, UPDATE, and DELETE operations were added.

Test Script Modifications:

  • The test script was updated to no longer rebuild the database after the binary format switch and upgrade.
    Instead, it verifies the continued functionality of existing data.

@congxuebin congxuebin requested a review from my-ship-it August 7, 2024 07:44
@avamingli
Copy link
Contributor

avamingli commented Aug 7, 2024

It' hard to tell if we could support binary switch with different versions.
Our codes changes catalog across minor versions, we can't promise binary switch.
I'm declined not to add these cases until we are ready to promise.

@congxuebin
Copy link
Contributor Author

congxuebin commented Aug 7, 2024

Hi Mingli, @avamingli

Thanks for the comment. Right, we cannot guarantee binary compatibility across all versions. But as discussed with Max, this test is limited to ensuring compatibility within specific version ranges. For example, it ensures compatibility between 1.6.x and 1.6.0 to facilitate customer upgrades. However, we consider 1.6.x and 1.7 to be incompatible. Would it make sense?
I added more information about the background of this in PR description.

@avamingli
Copy link
Contributor

For example, it ensures compatibility between 1.6.x and 1.6.0 to facilitate customer upgrades

Impossible, we changed catalog during Patch or revision versions. ex: gp_matview_aux, gp_matview_tables and etc.
This is different from GPDB, I think we will promise until there is a stable version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants