-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make gp-style partition table compatible with greenplum #695
Conversation
Please add some test cases, thanks |
Hi, I have failure with this change
|
Oh, sorry, looks like this is not related to current pr. I will take a look. Issue persist on master |
|
I found another issue #698. we can fix this within this pr, or i can created separate pr for this. |
Sure, the PR isn't fully ready yet. I'll some the full test when inherited encoding attributes are supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, now lets run the tests.
08bc07c
to
2180676
Compare
10badcc
to
35211f2
Compare
Hi @reshke Do you link your GitHub account with your Apache ID? It seems that your approval does not have binding access. Welcome to visit https://gitbox.apache.org/boxer/ to double-check. |
d9259f3
to
bdc7f6c
Compare
Currently, the child partition doesn't inherit the table access method, column encoding and reloptions from its parent table when the child table is added later. The change causes in-compatible behavior for users from gpdb. To achieve the target, the kernel saves table access method in pg_class for gp-style partition table, to be inherited by the child table. Reloption and column encoding of the child partitions also inherits from its parent if they are absent. However, the bahaviors between greenplum and cloudberry are still not 100% compatible.
bdc7f6c
to
37a6034
Compare
Adding a new partition should have the same behavior like greenplum 6/7.
The child partition inherits access method, reloptions, column encodings
from its parent if no specific options are provided
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel
cloudberrydb/dev
team for review and approval when your PR is ready🥳