Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic test selection and flexible defaults #805

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

edespino
Copy link
Contributor

Enhances the Cloudberry workflow test configuration with:

  • Adds workflow_dispatch input for comma-separated test selection
  • Introduces prepare-test-matrix job with centralized default values:
  • num_primary_mirror_pairs: 3
  • enable_cgroups: false
  • enable_core_check: true
  • pg_settings.optimizer: ""
  • Simplifies test definitions by only requiring explicit overrides for:
  • ic-fixme: enable_core_check: false
  • ic-isolation2-crash: enable_core_check: false
  • ic-resgroup-v2: enable_cgroups: true
  • ic-singlenode: num_primary_mirror_pairs: 0
  • ic-good-opt-off: pg_settings.optimizer: "off"

The changes allow:

  1. Running specific tests via workflow_dispatch
  2. Easier maintenance through centralized defaults
  3. Cleaner test configurations by removing redundant settings
  4. Better overview of test-specific requirements

Original test behavior is preserved while improving maintainability and flexibility of the configuration.

Enhances the Cloudberry workflow test configuration with:

* Adds workflow_dispatch input for comma-separated test selection
* Introduces prepare-test-matrix job with centralized default values:
 - num_primary_mirror_pairs: 3
 - enable_cgroups: false
 - enable_core_check: true
 - pg_settings.optimizer: ""
* Simplifies test definitions by only requiring explicit overrides for:
 - ic-fixme: enable_core_check: false
 - ic-resgroup-v2: enable_cgroups: true
 - ic-singlenode: num_primary_mirror_pairs: 0
 - ic-good-opt-off: pg_settings.optimizer: "off"

The changes allow:
1. Running specific tests via workflow_dispatch
2. Easier maintenance through centralized defaults
3. Cleaner test configurations by removing redundant settings
4. Better overview of test-specific requirements

Original test behavior is preserved while improving maintainability and
flexibility of the configuration.
@my-ship-it my-ship-it merged commit 589191e into apache:main Dec 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants