Support multi stage hashagg for groupingsets with unsortable refs #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4056) We already support multi stage hashagg for groupingset by this commit 9a790f8. There is no need to bail out if there are any unsortable refs.
Note that lc_monetary and lc_time are related to formatting output data. Besides, formatting functions will be pushed down to QEs in some common cases. So to keep the output data consistent with the locale value set in QD, we need to sync these GUCs between QD and QEs. Co-authored-by: wuchengwen <wcw190496@alibaba-inc.com>
"ini" is the filename extension of configuration files, use "initfile" instead. This commit also fixes some typos.
GlobalShellExecutor checks `o.endswith(GlobalShellExecutor.BASH_PS1)` before, there is a possibility that the current `o` only has several ending characters of the `GlobalShellExecutor.BASH_PS1`, in that case it never terminates but times out. This commit checks the whole output instead.
Currently, the gpinitsystem Behave tests fail because of environment variables being set in the tests not being unset/reset. Subsequent tests after an environment variable is set are affected and could fail if related (e.g. the locale tests). It didn't help that our Behave steps relating to environment variables were not working cohesively as well. The step to set the environment variable was not storing the original into the context for the other two steps to use. The step to unset the environment variable was not being used properly in our Behave tests because the step format did not have double quotes whereas all step references were double-quoting the environment variable. The previously unused step to restore the environment variable did not properly check for None values and would have also been confused with the double quotes if used. Fix the gpinitsystem Behave tests by fixing the mgmt_utils steps relating to environment variables and make sure to unset environment variables at the end of relevant Behave tests.
Removed as there is no functional difference after removing the older query. No reg is found from 6x to 7x.
Authored-by: Zhang Mingli avamingli@gmail.com
my-ship-it
previously approved these changes
Dec 24, 2024
Authored-by: Zhang Mingli avamingli@gmail.com
my-ship-it
approved these changes
Dec 25, 2024
yjhjstz
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions