Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update appendonlyblockdirectory.c: imporve coding style. #811

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reshke
Copy link
Contributor

@reshke reshke commented Dec 24, 2024

Completely remove code pattern unnatural for PostgreSQL kernel code style.

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


Completely remove code pattern unnatural for PostgreSQL kernel code style.
@my-ship-it
Copy link
Contributor

@wenchaozhang-123 Please help review the codes.

@wenchaozhang-123
Copy link
Contributor

Please fix CI failed.

return false;

if (entry_no == -1)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this square bracket?

@reshke
Copy link
Contributor Author

reshke commented Dec 27, 2024

i will update this shortly - im sorry for delay. Been busy fixing things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants