Cherrypick "Orca enable update and delete on partitioned tables (#14129)" #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaqizho
force-pushed
the
cherry-pick-orca-in-path-order-3
branch
from
23d9c0f to
2681d34
Compare
Commit 89522085ad9 adds back dynamic scan nodes which requires a different
execution model for modifying partitioned tables. After this change we cannot
assume that the modify table relation directly references a leaf partition.
Instead, dynamic scan node references a root partition and requires tuple
routing in order to find the leaf partition.
This commit provides the framework to force tuple routing and updates the ORCA
side to allow generation of DML plans on partitioned tables. There is no longer
a need for ORCA to generate a partition selector node and OIDs. Instead, that
work is now handled in the tuple routing framework.
After this commit, ORCA is able to handle UPDATE/DELETE on partition tables:
```sql
CREATE TABLE pt (a int, b int) PARTITION BY RANGE(b) (START (0) END (7) EVERY (3));
INSERT INTO pt SELECT i, i%6 FROM generate_series(1, 100)i;
UPDATE pt SET b=5 WHERE b=2;
DELETE FROM pt WHERE b=1;
```
Example DELETE plan:
```
QUERY PLAN
------------------------------------------
Delete on pt
-> Dynamic Seq Scan on pt pt_1
Number of partitions to scan: 1
Filter: (b = 1)
Optimizer: Pivotal Optimizer (GPORCA)
```
And the plan node looks something like:
```
{PLANNEDSTMT
:commandType 4
:planGen 1
...
:planTree
{MODIFYTABLE
...
:plans (
{DYNAMICSEQSCAN
:scanrelid 2
:partOids (o 286823)
...
}
)
...
}
}
```
jiaqizho
force-pushed
the
cherry-pick-orca-in-path-order-3
branch
2 times, most recently
from
0729f30 to
f6b4497
Compare
After CBDB merged with PG14, we need to provide additional support for the case where the update/delete is a dynamic (any) scan operator. This is because in `ExecModifyTable`, PG14 has an assumption: the current `resultRelInfo` will not be a root partition table. The current commit disables the update/delete generated by ORCA on the partition table, and this behavior will be supported in subsequent changes.
jiaqizho
force-pushed
the
cherry-pick-orca-in-path-order-3
branch
from
f6b4497 to
25f806d
Compare
yjhjstz
approved these changes
Jan 2, 2025
my-ship-it
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions