Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean some typos about IVM #825

Merged
merged 4 commits into from
Dec 31, 2024
Merged

Conversation

hyongtao-db
Copy link
Contributor

@hyongtao-db hyongtao-db commented Dec 30, 2024

No code changes. Just clean some typos about IVM‘s comments.
Parts of typos are from pg_ivm.
Signed-off-by: Yongtao Huang yongtaoh2022@gmail.com

my-ship-it
my-ship-it previously approved these changes Dec 30, 2024
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

avamingli
avamingli previously approved these changes Dec 30, 2024
@yjhjstz
Copy link
Member

yjhjstz commented Dec 31, 2024

 -- contain HAVING
 CREATE INCREMENTAL MATERIALIZED VIEW mv_ivm08 AS SELECT i,j,k FROM mv_base_a a INNER JOIN mv_base_b b USING(i) GROUP BY i,j,k HAVING SUM(i) > 5;
-ERROR:   HAVING clause is not supported on incrementally maintainable materialized view
+ERROR:  HAVING clause is not supported on incrementally maintainable materialized view
 -- contain view or materialized view
 CREATE VIEW b_view AS SELECT i,k FROM mv_base_b;
 CREATE MATERIALIZED VIEW b_mview AS SELECT i,k FROM mv_base_b;

need fix ci.

@hyongtao-db
Copy link
Contributor Author

 -- contain HAVING
 CREATE INCREMENTAL MATERIALIZED VIEW mv_ivm08 AS SELECT i,j,k FROM mv_base_a a INNER JOIN mv_base_b b USING(i) GROUP BY i,j,k HAVING SUM(i) > 5;
-ERROR:   HAVING clause is not supported on incrementally maintainable materialized view
+ERROR:  HAVING clause is not supported on incrementally maintainable materialized view
 -- contain view or materialized view
 CREATE VIEW b_view AS SELECT i,k FROM mv_base_b;
 CREATE MATERIALIZED VIEW b_mview AS SELECT i,k FROM mv_base_b;

need fix ci.

Thank you. I will do it.

@my-ship-it my-ship-it merged commit 47fe6d9 into apache:main Dec 31, 2024
22 checks passed
@hyongtao-db hyongtao-db deleted the clean-ivm-typo branch January 1, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants