Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert GET to POST requests #140

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Aug 10, 2023

Fixes #139

@weizhouapache
Copy link
Member

@Pearl1594
just for your information, cloudstack UI sends POST request if userdata is present.

        const httpMethod = deployVmData.userdata ? 'POST' : 'GET'
        const args = httpMethod === 'POST' ? {} : deployVmData
        const data = httpMethod === 'POST' ? deployVmData : {}

        api('deployVirtualMachine', args, httpMethod, data).then(response => {

see https://github.com/apache/cloudstack/blob/main/ui/src/views/compute/DeployVM.vue#L2167-L2171

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Aug 10, 2023

@Pearl1594 you probably don't want to do this as a default, we need to check if mgmt server logs API requests when things are POST-ed. You can probably add conditionals for new user-data related APIs.

@hrak did you face issues when using the deploy VM API or other user-data related APIs?
cc @harikrishna-patnala did we enable the UI at least to handle POST in case of large user-data content?

@Pearl1594
Copy link
Contributor Author

@weizhouapache @rohityadavcloud I was just testing to see if there is any issue with using POST for all commands. Hence raised this draft PR.

@hrak
Copy link

hrak commented Aug 11, 2023

cloudstack-go also uses POST by default for both DeployVirtualMachine and UpdateVirtualMachine, but i wouldn't use POST for everything as this PR seems to do.

@hrak
Copy link

hrak commented Aug 11, 2023

@hrak did you face issues when using the deploy VM API or other user-data related APIs?

Yes, i can't submit userdata > 4K using Cloudmonkey.

@rohityadavcloud
Copy link
Member

@Pearl1594 isn't deploy VM using POST in cmk?

@Pearl1594
Copy link
Contributor Author

@rohityadavcloud No, deployVM is a GET request. I'll identify the commands that use POST and update the PR, that said, all operations seem to work fine using post

@rohityadavcloud
Copy link
Member

@Pearl1594 I suppose a simple fix could be something like if the request size is say > 2048 or > 4096 then use POST, otherwise use GET. One thing we must check if when we use POST APIs, does cloudstack log them (for debugging/support purposes).

@weizhouapache
Copy link
Member

@Pearl1594 I suppose a simple fix could be something like if the request size is say > 2048 or > 4096 then use POST, otherwise use GET. One thing we must check if when we use POST APIs, does cloudstack log them (for debugging/support purposes).

or use POST if userdata or password is passed.

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, haven't tested it though

@weizhouapache
Copy link
Member

@hrak
can you please test this ?

@mlsorensen
Copy link
Contributor

mlsorensen commented Oct 13, 2023

Can we get a config item for the user to choose POST or not e.g. set method [post|get]? This may be desirable for other calls that may contain large payload or secret data (like the cert APIs), and it may be easier to provide generic functionality even if it makes the user have an alternate profile.

@mlsorensen
Copy link
Contributor

mlsorensen commented Oct 25, 2023

FYI - I tested this out and am getting auth errors via keys if I try to call deploy virtualmachine or update virtualmachine with large userdata. I wonder if it is generating the signature with the userdata as a URL param, but then posting it without the userdata in the URL, or something like that.

% ./cmk
Apache CloudStack 🐵 CloudMonkey 6.4.0-rc
Report issues: https://github.com/apache/cloudstack-cloudmonkey/issues

🐱 > deploy virtualmachine ...

🙈 Error: failed to authenticate, please check the credentials

I did not run in debug mode so I didn't capture that output, but retrying without the userdata worked. Then trying to update virtualmachine to apply the userdata afterword failed with same error.

@rohityadavcloud
Copy link
Member

@mlsorensen can you share a test userdata string/content for us to test/reproduce it? Could you also check mgmt server logs (share the same)? It could be a limitation/issue in cmk or backend mgmt server.

cmd/network.go Outdated Show resolved Hide resolved
@rohityadavcloud
Copy link
Member

@DaanHoogland @Pearl1594 is there a way you could test against large userdata input string to see how it behaves wrt post vs get request?

@DaanHoogland
Copy link
Contributor

after a short discuss off(this)line with @Pearl1594 , the performance is not very relevant as with only 2kb of url length userdata is going to be too long easily. If we wish we can implement a flag to try get first or a flag to use get (or post) for deploymachine. I think this is out of scope for this PR, though.

@DaanHoogland DaanHoogland marked this pull request as ready for review November 6, 2023 15:21
@DaanHoogland
Copy link
Contributor

liberally stealing from my chat with @Pearl1594;
before :

(nsx) 🐱 > deploy virtualmachine name=test-cmk-post-ud serviceofferingid=cbbe6556-3bdb-4bc7-92f6-93abc628e69e  templateid=73c7dddb-77ee-11ee-863b-1e0093000c63  zoneid=daa697fd-5629-4623-97d4-af4297f2dc16  userdata="cXdlcnR5dWlvcGFzZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wYXNkZmdoamtsenhjdmJubXF3ZXJ0eXVpb3Bhc2RmZ2hqa2x4Y2JubSxxd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tcXdlcnR5dWlvZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tb3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0b3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0cXdlcnR5dWlvcGFzZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wYXNkZmdoamtsenhjdmJubXF3ZXJ0eXVpb3Bhc2RmZ2hqa2x4Y2JubSxxd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tcXdlcnR5dWlvZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tb3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0b3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0" networkids=70522d4a-0d14-435c-82e0-8205c5bd16a2 
🙈 Error: (HTTP 431, error code 4350) User data is too long for an http GET request

after:

(nsx) 🐱 > deploy virtualmachine name=test-cmk-post-ud2 serviceofferingid=cbbe6556-3bdb-4bc7-92f6-93abc628e69e  templateid=73c7dddb-77ee-11ee-863b-1e0093000c63  zoneid=daa697fd-5629-4623-97d4-af4297f2dc16  userdata="cXdlcnR5dWlvcGFzZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wYXNkZmdoamtsenhjdmJubXF3ZXJ0eXVpb3Bhc2RmZ2hqa2x4Y2JubSxxd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tcXdlcnR5dWlvZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tb3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0b3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0cXdlcnR5dWlvcGFzZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wYXNkZmdoamtsenhjdmJubXF3ZXJ0eXVpb3Bhc2RmZ2hqa2x4Y2JubSxxd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tcXdlcnR5dWlvZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tb3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0b3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0" networkids=70522d4a-0d14-435c-82e0-8205c5bd16a2
{
  "virtualmachine": {
    "account": "admin",
    "affinitygroup": [],
    "cpunumber": 1,
    "cpuspeed": 500,
    "created": "2023-11-06T14:41:34+0000",
    "details": {
      "cpuOvercommitRatio": "2.0",
      "dataDiskController": "osdefault",
      "memoryOvercommitRatio": "1.0",
      "rootDiskController": "ide"
    },
    "displayname": "test-cmk-post-ud2",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "73c14442-77ee-11ee-863b-1e0093000c63",
    "guestosid": "73caacda-77ee-11ee-863b-1e0093000c63",
    "haenable": false,
    "hasannotations": false,
    "hostcontrolstate": "Enabled",
    "hostid": "9b1c77c0-63ee-40d4-83d7-13aa3d6ad5c6",
    "hostname": "env03esx02.ll",
    "hypervisor": "VMware",
    "id": "63e53a5f-03a6-4483-be22-d8faf47af912",
    "instancename": "i-2-84-VM",
    "isdynamicallyscalable": false,
    "jobid": "ff2b625d-fb28-48a9-a8fc-2b71397b35c2",
    "jobstatus": 0,
    "lastupdated": "2023-11-06T14:41:53+0000",
    "memory": 512,
    "name": "test-cmk-post-ud2",
    "nic": [
      {
        "broadcasturi": "nsx://nsx",
        "deviceid": "0",
        "extradhcpoption": [],
        "gateway": "10.1.1.1",
        "id": "33de3a4d-214b-49ab-9848-d88cf8fca5ca",
        "ipaddress": "10.1.1.158",
        "isdefault": true,
        "isolationuri": "nsx://nsx",
        "macaddress": "02:01:00:d7:00:06",
        "netmask": "255.255.255.0",
        "networkid": "70522d4a-0d14-435c-82e0-8205c5bd16a2",
        "networkname": "iso1",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      }
    ],
    "osdisplayname": "CentOS 5.3 (64-bit)",
    "ostypeid": "73caacda-77ee-11ee-863b-1e0093000c63",
    "passwordenabled": false,
    "pooltype": "NetworkFilesystem",
    "receivedbytes": 0,
    "rootdeviceid": 0,
    "rootdevicetype": "ROOT",
    "securitygroup": [],
    "sentbytes": 0,
    "serviceofferingid": "cbbe6556-3bdb-4bc7-92f6-93abc628e69e",
    "serviceofferingname": "Small Instance",
    "state": "Running",
    "tags": [],
    "templatedisplaytext": "CentOS 5.3(64-bit) no GUI (vSphere)",
    "templateid": "73c7dddb-77ee-11ee-863b-1e0093000c63",
    "templatename": "CentOS 5.3(64-bit) no GUI (vSphere)",
    "templatetype": "BUILTIN",
    "userid": "a13b78f5-77ee-11ee-863b-1e0093000c63",
    "username": "admin",
    "zoneid": "daa697fd-5629-4623-97d4-af4297f2dc16",
    "zonename": "ZoneNSX"
  }
}

@DaanHoogland DaanHoogland merged commit e19c4f6 into main Nov 6, 2023
2 checks passed
@DaanHoogland DaanHoogland deleted the bug/139-support-post-method branch November 6, 2023 15:38
@rohityadavcloud rohityadavcloud added this to the 6.4.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support POST method
6 participants