Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make mockgen for modern versions? #83

Merged
merged 1 commit into from
Apr 23, 2024
Merged

make mockgen for modern versions? #83

merged 1 commit into from
Apr 23, 2024

Conversation

DaanHoogland
Copy link
Contributor

just install the thing

Pearl1594
Pearl1594 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - LGTM

Removed mockgen from ~/go/bin/
And ran make mockgen downloaded the necessary dependency.

@DaanHoogland DaanHoogland merged commit 0d335ef into apache:main Apr 23, 2024
1 check passed
@DaanHoogland DaanHoogland deleted the makemockgen branch April 23, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

@vishesh92 vishesh92 Awaiting requested review from vishesh92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaanHoogland @Pearl1594