Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test data for register userkeys #99

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Add test data for register userkeys #99

merged 2 commits into from
Dec 31, 2024

Conversation

Pearl1594
Copy link
Contributor

No description provided.

@DaanHoogland
Copy link
Contributor

@Pearl1594 is this solving #96 or does it relate in some other way?

@Pearl1594
Copy link
Contributor Author

I only raised this PR to run the tests.. Will close it once I receive some update on the issue #96

@DaanHoogland
Copy link
Contributor

@Pearl1594 , we shouldn´t add the test dat for future testing either?

@Pearl1594 Pearl1594 marked this pull request as ready for review December 31, 2024 12:03
@Pearl1594
Copy link
Contributor Author

We could add it.

DaanHoogland
DaanHoogland reviewed Dec 31, 2024
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, (de)pending possible addition of tests.

test/testdata/UserService.json Outdated Show resolved Hide resolved
@Pearl1594 Pearl1594 merged commit bfc6c0c into main Dec 31, 2024
1 check passed
@DaanHoogland DaanHoogland deleted the fix-register-userkeys branch January 2, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pearl1594 @DaanHoogland