Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fixes in the Usage UI #10000

Merged
merged 9 commits into from
Dec 9, 2024
Merged

Conversation

bernardodemarco
Copy link
Collaborator

@bernardodemarco bernardodemarco commented Nov 28, 2024

Description

This PR addresses the following issues related to the Usage UI:

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

  • Usage UI view when the user does not have access to the listUsageServerMetrics, removeRawUsageRecords, generateUsageRecords and listUsageTypes APIs

image

How Has This Been Tested?

  • Verified that users without access to the listUsageServerMetrics, removeRawUsageRecords, generateUsageRecords and listUsageTypes APIs were not able to interact with them through the UI.
  • Verified that the vertical overflow issue was resolved.

@bernardodemarco bernardodemarco changed the base branch from main to 4.20 November 28, 2024 00:47
@bernardodemarco
Copy link
Collaborator Author

@blueorangutan ui

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.80%. Comparing base (c63c7ee) to head (fa9bfba).
Report is 37 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #10000      +/-   ##
============================================
- Coverage     15.80%   15.80%   -0.01%     
+ Complexity    12586    12585       -1     
============================================
  Files          5627     5627              
  Lines        492343   492349       +6     
  Branches      59694    59696       +2     
============================================
- Hits          77828    77826       -2     
- Misses       405992   405999       +7     
- Partials       8523     8524       +1     
Flag Coverage Δ
uitests 4.04% <ø> (-0.01%) ⬇️
unittests 16.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10000 (QA-JID-488)

@DaanHoogland DaanHoogland added this to the 4.20.1 milestone Nov 28, 2024
Copy link
Collaborator

@winterhazel winterhazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, verified in a local lab.

Just one thing: the last heartbeat may be undefined. We could show something like "never" instead of "null" for the last heartbeat for this case.

image

@bernardodemarco
Copy link
Collaborator Author

Just one thing: the last heartbeat may be undefined. We could show something like "never" instead of "null" for the last heartbeat for this case.

@winterhazel, done

image

@winterhazel
Copy link
Collaborator

Just one thing: the last heartbeat may be undefined. We could show something like "never" instead of "null" for the last heartbeat for this case.

@winterhazel, done

image

It would also be good to change the "a few seconds ago" in this case

@bernardodemarco
Copy link
Collaborator Author

It would also be good to change the "a few seconds ago" in this case

Done.

image

@rohityadavcloud
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10000 (QA-JID-490)

ui/src/views/infra/UsageRecords.vue Outdated Show resolved Hide resolved
ui/src/views/infra/UsageRecords.vue Outdated Show resolved Hide resolved
ui/src/views/infra/UsageRecords.vue Outdated Show resolved Hide resolved
ui/src/views/infra/UsageRecords.vue Outdated Show resolved Hide resolved
ui/src/views/infra/UsageRecords.vue Outdated Show resolved Hide resolved
bernardodemarco and others added 5 commits November 29, 2024 10:25
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
@bernardodemarco
Copy link
Collaborator Author

@blueorangutan ui

@blueorangutan
Copy link

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10000 (QA-JID-491)

@JoaoJandre JoaoJandre merged commit e57a82a into apache:4.20 Dec 9, 2024
26 checks passed
DaanHoogland added a commit that referenced this pull request Dec 20, 2024
* 4.20:
  VR: apply iptables rules when add/remove static routes (#10064)
  Certificate and VM hostname validation improvements (#10051)
  set ulimit for server according to redhat spec (#10040)
  kvm-storage: provide isVMMigrate information to storage plugins (#10093)
  Allow config drive deletion of migrated VM, on host maintenance (#10045)
  linstor: improve heartbeat check with also asking linstor (#10105)
  server: simplify role change validation (#9173)
  UI: create VPC network offering with conserve mode (#10082)
  server: fix typo removeaccessvpn in VirtualRouterElement (#10086)
  UI: remove duplicated Instance Name in Public IP details page (#10087)
  UI: Fixes in the Usage UI (#10000)
  SAML2: add cookie with HttpOnly too #10013 (#10047)
  ui: Allow font-awesome icon usage and optimise icon size inconsistency (#9744)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 26, 2024
* fixes on usage ui

* dont call API when caller does not have access to it

* handle when lastheartbeat is undefined

* hide last collection datetime when lastheartbeat is undefined

* apply Pearl's suggestions

Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

* apply Pearl's suggestions

Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

* apply Pearl's suggestions

Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

* apply Pearl's suggestions

Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

* apply Pearl's suggestions

Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

---------

Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants