-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Fixes in the Usage UI #10000
UI: Fixes in the Usage UI #10000
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10000 +/- ##
============================================
- Coverage 15.80% 15.80% -0.01%
+ Complexity 12586 12585 -1
============================================
Files 5627 5627
Lines 492343 492349 +6
Branches 59694 59696 +2
============================================
- Hits 77828 77826 -2
- Misses 405992 405999 +7
- Partials 8523 8524 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@winterhazel, done |
It would also be good to change the "a few seconds ago" in this case |
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
* 4.20: VR: apply iptables rules when add/remove static routes (#10064) Certificate and VM hostname validation improvements (#10051) set ulimit for server according to redhat spec (#10040) kvm-storage: provide isVMMigrate information to storage plugins (#10093) Allow config drive deletion of migrated VM, on host maintenance (#10045) linstor: improve heartbeat check with also asking linstor (#10105) server: simplify role change validation (#9173) UI: create VPC network offering with conserve mode (#10082) server: fix typo removeaccessvpn in VirtualRouterElement (#10086) UI: remove duplicated Instance Name in Public IP details page (#10087) UI: Fixes in the Usage UI (#10000) SAML2: add cookie with HttpOnly too #10013 (#10047) ui: Allow font-awesome icon usage and optimise icon size inconsistency (#9744)
* fixes on usage ui * dont call API when caller does not have access to it * handle when lastheartbeat is undefined * hide last collection datetime when lastheartbeat is undefined * apply Pearl's suggestions Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> * apply Pearl's suggestions Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> * apply Pearl's suggestions Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> * apply Pearl's suggestions Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> * apply Pearl's suggestions Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> --------- Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Description
This PR addresses the following issues related to the Usage UI:
null
values to users without access to thelistUsageServerMetrics
API (Fixes Usage server metrics section shown to users without access to the API #9992);removeRawUsageRecords
API (Fixes Purge usage records action shown to users without access toremoveRawUsageRecords
#9995);generateUsageRecords
API (Fixes Generate usage records action shown to users without access togenerateUsageRecords
#9994);listUsageTypes
API. Since theusageid
parameter of thelistUsageRecords
API can only be used alongside thetype
parameter, both form fields are now hidden when the caller does not have access to thelistUsageTypes
API.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
listUsageServerMetrics
,removeRawUsageRecords
,generateUsageRecords
andlistUsageTypes
APIsHow Has This Been Tested?
listUsageServerMetrics
,removeRawUsageRecords
,generateUsageRecords
andlistUsageTypes
APIs were not able to interact with them through the UI.