Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix Create dropdown menu not changing language dynamically #10023

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

lucas-a-martins
Copy link
Contributor

Description

This PR fixes the bug presented in the issue #10010, where the Create dropdown menu language does not change dynamically, requiring a reload of the entire screen.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

I tested the changes by setting the UI to a different language in the login screen and then changing to another after login, I also changed the language multiple times in the Dashboard screen. The Create menu language changed every time as expected.

@rohityadavcloud
Copy link
Member

@lucas-a-martins thanks for the PR, is this only specific changes you've identified or is this a pattern across all of the UI config?

@DaanHoogland DaanHoogland added this to the 4.20.1 milestone Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.98%. Comparing base (58138f2) to head (7b33d31).
Report is 23 commits behind head on 4.20.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #10023   +/-   ##
=========================================
  Coverage     15.98%   15.98%           
  Complexity    12753    12753           
=========================================
  Files          5631     5631           
  Lines        492702   492702           
  Branches      59737    59737           
=========================================
  Hits          78755    78755           
  Misses       405219   405219           
  Partials       8728     8728           
Flag Coverage Δ
uitests 4.03% <ø> (ø)
unittests 16.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucas-a-martins
Copy link
Contributor Author

@lucas-a-martins thanks for the PR, is this only specific changes you've identified or is this a pattern across all of the UI config?

@rohityadavcloud this is the only case were I saw this happening, because this specific menu had it's translation defined in the beforeCreate lifecycle. I'm gonna take a closer look into this behavior from now on.

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10023 (QA-JID-494)

Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Tested manually, the language changes for the create menu successfully

@DaanHoogland DaanHoogland merged commit 4c801e2 into apache:4.20 Dec 5, 2024
24 of 25 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 12, 2024
Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants