Create new Instance from VM backup

[abh1sar]

Doc PR: apache/cloudstack-documentation#474

Description

This PR adds the ability to create a new Instance from a VM backup for Dummy, NAS and Veeam backup Providers.
This will still work if the original Instance used to create the backup was expunged.

New API

• createVmFromBackup extends deployVIrtualMachine
• new argument : backupId
• User can just specify the backupId and a new instance will be created by getting the VM and volumes' configuration stored in backup_details table.
• User can also choose to configure the details themselves using the parameters present in deployVIrtualMachine cmd

UI

• New action button in backups list view - 'Create Instance from Backup'
• User can choose to directly create the VM or configure VM parameters before creating it.

DB changes

• New backup_details table
• to store vm config data such as templateUuid, serviceOfferingUuid, hypervisor, networkUuids
• to store volumes config data such as diskOfferingUuids, size, miniops and maxiops for custom disk offerings.

Other Changes

• Added new parameter Map datadisksdetails to deployVirtualMachine api to create multiple data volumes at the time of instance creation.

Plugins related changes

• NAS and Veeam plugin changes to restore backup to a new VM.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 27.50846% with 643 lines in your changes missing coverage. Please review.

Project coverage is 16.17%. Comparing base (69cf299) to head (4197912).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	33.48%	114 Missing and 31 partials ⚠️
...rg/apache/cloudstack/backup/BackupManagerImpl.java	66.86%	34 Missing and 23 partials ⚠️
...ack/api/command/user/vm/CreateVMFromBackupCmd.java	3.57%	54 Missing ⚠️
...rg/apache/cloudstack/backup/dao/BackupDaoImpl.java	0.00%	49 Missing ⚠️
...a/org/apache/cloudstack/backup/BackupDetailVO.java	0.00%	37 Missing ⚠️
...rc/main/java/com/cloud/alert/AlertManagerImpl.java	6.25%	30 Missing ⚠️
...apache/cloudstack/api/response/BackupResponse.java	0.00%	24 Missing ⚠️
...in/java/org/apache/cloudstack/backup/BackupVO.java	11.53%	23 Missing ⚠️
...he/cloudstack/api/command/user/vm/DeployVMCmd.java	50.00%	10 Missing and 10 partials ⚠️
...che/cloudstack/backup/NetworkerBackupProvider.java	0.00%	18 Missing ⚠️
... and 26 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10140      +/-   ##
============================================
+ Coverage     16.15%   16.17%   +0.02%     
- Complexity    13273    13306      +33     
============================================
  Files          5666     5672       +6     
  Lines        498081   499793    +1712     
  Branches      60267    60594     +327     
============================================
+ Hits          80475    80857     +382     
- Misses       408593   409829    +1236     
- Partials       9013     9107      +94     

Flag	Coverage Δ
uitests	3.89% <ø> (-0.12%)	⬇️
unittests	17.05% <27.50%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leo79901]

Yes, we need this !

[abh1sar]

@blueorangutan package

[blueorangutan]

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11996

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[shwstppr]

Code LGTM

@abh1sar only one diskoffering - zone link edge case seems to be remaining for testing/changes
Please see if we need to add some documentation for the feature

@blueorangutan package

[abh1sar]

one diskoffering - zone link edge case seems to be remaining for testing/changes
Please see if we need to add some documentation for the feature

thanks @shwstppr
I have fixed the disk-offering edge case and catch all exceptions plus some minor UI fixes. Also linked doc PR.

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.