Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: add support for VMware 7.0 dependency and hypervisor capability #4300

Merged
merged 1 commit into from
Apr 15, 2021
Merged

engine: add support for VMware 7.0 dependency and hypervisor capability #4300

merged 1 commit into from
Apr 15, 2021

Conversation

rohityadavcloud
Copy link
Member

@rohityadavcloud rohityadavcloud commented Sep 1, 2020 •
edited by DaanHoogland
Loading

This adds support for VMware 7.0 with a jar dependency and sql upgrade path. The jar dependency has been added to support noredist pkging here:
https://github.com/rhtyd/cloudstack-nonoss/blob/master/install-non-oss.sh#L37

Fixes #4441
Fixes #4423

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@rohityadavcloud rohityadavcloud added this to the 4.16.0.0 milestone Sep 1, 2020
@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1865

@rohityadavcloud
Copy link
Member Author

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

10 similar comments
@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@apache apache deleted a comment from blueorangutan Sep 7, 2020
@rohityadavcloud
Copy link
Member Author

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-2694)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 77101 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t2694-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 78 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_add_delete_kubernetes_supported_version Error 970.19 test_kubernetes_supported_versions.py
test_07_reboot_ssvm Failure 41.90 test_ssvm.py
test_08_reboot_cpvm Failure 42.89 test_ssvm.py

@rohityadavcloud
Copy link
Member Author

Kicked tests against vCenter 7 based env.

@rohityadavcloud
Copy link
Member Author

Marvin tests with this PR and vCenter 7.0 with CentOS7 mgmt server but two 6.7u3 ESXi hosts:

Test Result Time (s) Test File
test_01_deploy_kubernetes_cluster Error 0.15 test_kubernetes_clusters.py
test_02_deploy_kubernetes_ha_cluster Error 0.07 test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster Error 0.06 test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster Error 0.07 test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster Error 0.06 test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster Error 0.06 test_kubernetes_clusters.py
test_01_add_primary_storage_disabled_host Error 0.51 test_primary_storage.py
test_01_primary_storage_nfs Error 0.18 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.31 test_primary_storage.py
test_02_list_snapshots_with_removed_data_store Error 1.21 test_snapshots.py
test_02_create_template_with_checksum_sha1 Error 5.28 test_templates.py
test_03_create_template_with_checksum_sha256 Error 5.20 test_templates.py
test_04_create_template_with_checksum_md5 Error 5.20 test_templates.py
test_01_volume_usage Error 11.57 test_usage.py
test_11_migrate_vm Error 50.32 test_vm_life_cycle.py
test_01_create_volume Error 134.77 test_volumes.py
test_02_attach_volume Error 44.96 test_volumes.py
test_03_download_attached_volume Error 1.10 test_volumes.py
test_04_delete_attached_volume Error 1.11 test_volumes.py
test_05_detach_volume Error 1.10 test_volumes.py
test_06_download_detached_volume Error 1.11 test_volumes.py
test_07_resize_fail Error 2.28 test_volumes.py
test_08_resize_volume Error 1.11 test_volumes.py
test_09_delete_detached_volume Error 12.63 test_volumes.py
test_11_attach_volume_with_unstarted_vm Error 2.39 test_volumes.py
ContextSuite context=TestVolumes>:teardown Error 19.09 test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 443.14 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Error 3790.27 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Error 3790.31 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 0.01 test_vpc_redundant.py
ContextSuite context=TestVPCRedundancy>:teardown Error 0.02 test_vpc_redundant.py

@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2250

@rohityadavcloud
Copy link
Member Author

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 377

@nvazquez
Copy link
Contributor

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-399)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37625 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t399-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestVAppsVM>:setup Error 82.81 test_vm_life_cycle.py

@rohityadavcloud
Copy link
Member Author

@nvazquez can you kick smoketests against vmware 7.0 as well? And if we can get support for vsphere7 in Trillian?

@nvazquez
Copy link
Contributor

@blueorangutan help

@blueorangutan
Copy link

@nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']

@apache apache deleted a comment from blueorangutan Apr 14, 2021
@nvazquez
Copy link
Contributor

@blueorangutan help

@blueorangutan
Copy link

@nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-70u1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']

@nvazquez
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 411

@nvazquez
Copy link
Contributor

@blueorangutan test centos7 vmware-70u1

@apache apache deleted a comment from blueorangutan Apr 14, 2021
@apache apache deleted a comment from blueorangutan Apr 14, 2021
@blueorangutan
Copy link

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-441)
Environment: vmware-70u1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36325 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t441-vmware-70u1.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_10_traceroute_in_vr Failure 61.16 test_diagnostics.py
test_01_redundant_vpc_site2site_vpn Failure 347.83 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 243.03 test_vpc_vpn.py

@nvazquez
Copy link
Contributor

@rhtyd @vladimirpetrov Vmware 7.0 support was introduced into Trillian and the last tests were executed on it, few errors which seem unrelated to this PR. Please advise if we are ready to merge it

@rohityadavcloud
Copy link
Member Author

LGTM, @vladimirpetrov are you lgtm on this?

vladimirpetrov
vladimirpetrov approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@vladimirpetrov vladimirpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing finished, LGTM @nvazquez, @rhtyd !

@rohityadavcloud
Copy link
Member Author

Merging based on tests and code reviews.

@rohityadavcloud rohityadavcloud merged commit 0302750 into apache:4.15 Apr 15, 2021
@rohityadavcloud rohityadavcloud mentioned this pull request Apr 15, 2021
Closed
@weizhouapache weizhouapache mentioned this pull request Sep 8, 2021
Closed
@weizhouapache weizhouapache mentioned this pull request Feb 1, 2022
Closed
DaanHoogland pushed a commit to shapeblue/cloudstack that referenced this pull request May 20, 2022
@rohityadavcloud
vmware: Add support for VMware 7 (apache#4300)
3ded352
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Jan 17, 2023
@rohityadavcloud @shwstppr
vmware: Add support for VMware 7 (apache#4300)
584cbff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpetrov vladimirpetrov vladimirpetrov approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@nvazquez nvazquez Awaiting requested review from nvazquez

@davidjumani davidjumani Awaiting requested review from davidjumani

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

@rohityadavcloud rohityadavcloud

@nvazquez nvazquez

Labels
component:vmware
Projects
None yet
Milestone
4.15.1.0
Development

Successfully merging this pull request may close these issues.

cpvm not support VMware 7.0 console Adding a cluster
8 participants
@rohityadavcloud @blueorangutan @nvazquez @DaanHoogland @sureshanaparti @vladimirpetrov @PaulAngus @ACSGitBot