-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Details on add guest os optional #7812
Conversation
0b05864
to
a2e5b1a
Compare
@blueorangutan package |
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6650 |
Codecov Report
@@ Coverage Diff @@
## 4.18 #7812 +/- ##
============================================
- Coverage 13.02% 13.02% -0.01%
+ Complexity 9031 9029 -2
============================================
Files 2720 2720
Lines 257010 257010
Branches 40083 40083
============================================
- Hits 33472 33467 -5
- Misses 219336 219342 +6
+ Partials 4202 4201 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I don't think this will be touched by any smoke tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, already manually tested this change with PR #6979.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
Description
This PR fixes a issue reported in the user mail list: https://lists.apache.org/thread/clsoyz3kgp47ppbhtqp8m0o2fkczqrmk
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?