Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pom.xml reflections version #8019

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Update pom.xml reflections version #8019

merged 1 commit into from
Oct 16, 2023

Conversation

mlsorensen
Copy link
Contributor

Addresses bug described in reflections 0.9.12 ronmamo/reflections#273

Description

While developing new code against CloudStack, I ran into the bug described above in Reflections 0.9.12. Upgrading seems to resolve the issue.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@mlsorensen
Update pom.xml reflections version
3c87b33 
Addresses bug described in reflections 0.9.12 ronmamo/reflections#273
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #8019 (3c87b33) into 4.18 (221f863) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #8019   +/-   ##
=========================================
  Coverage     13.06%   13.06%           
- Complexity     9106     9107    +1     
=========================================
  Files          2720     2720           
  Lines        257506   257506           
  Branches      40149    40149           
=========================================
+ Hits          33649    33655    +6     
+ Misses       219627   219619    -8     
- Partials       4230     4232    +2

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@harikrishna-patnala
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@rohityadavcloud rohityadavcloud added this to the 4.19.0.0 milestone Sep 29, 2023
rohityadavcloud
rohityadavcloud approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we need to check/test if this causes regressions, otherwise let's merge

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7165

@DaanHoogland
Copy link
Contributor

@blueorangutan test matrix

@blueorangutan
Copy link

@DaanHoogland a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-7769)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51588 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8019-t7769-xenserver-71.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_invalid_upgrade_kubernetes_cluster Failure 3618.21 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 3612.97 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.07 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 0.11 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.03 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.03 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Failure 54.85 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 121.53 test_kubernetes_clusters.py
test_01_cancel_host_maintenace_with_no_migration_jobs Error 308.19 test_host_maintenance.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-7771)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51762 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8019-t7771-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_invalid_upgrade_kubernetes_cluster Failure 3616.46 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 3610.24 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 0.03 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 0.03 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.03 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Failure 44.71 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 112.29 test_kubernetes_clusters.py

@DaanHoogland
Copy link
Contributor

@blueorangutan test rocky8 vmware-70u3

@blueorangutan
Copy link

@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-7795)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 70368 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8019-t7795-vmware-70u3.zip
Smoke tests completed. 105 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_10_vpc_tier_kubernetes_cluster Failure 3721.20 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Error 3721.32 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 3759.73 test_kubernetes_clusters.py
test_01_deploy_vm_on_specific_host Error 12.61 test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster Error 3602.74 test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod Error 4.41 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 4.41 test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod Error 4.38 test_vm_deployment_planner.py
test_09_expunge_vm Failure 424.67 test_vm_life_cycle.py

@rohityadavcloud
Copy link
Member

CKS failures are intermittent/ignorable, I'm not sure about rest @DaanHoogland @harikrishna-patnala

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7225

@DaanHoogland
Copy link
Contributor

@blueorangutan test rocky8 vmware-70u3

@blueorangutan
Copy link

@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

@JoaoJandre JoaoJandre mentioned this pull request Oct 4, 2023
Merged
12 tasks
@blueorangutan
Copy link

[SF] Trillian test result (tid-7842)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 47703 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8019-t7842-vmware-70u3.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_upgrade_kubernetes_cluster Failure 666.53 test_kubernetes_clusters.py

@shwstppr
Copy link
Contributor

shwstppr commented Oct 9, 2023

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7267

weizhouapache
weizhouapache approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan LLtest matrix

@blueorangutan
Copy link

@DaanHoogland a [LL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[LL]Trillian test result (tid-6799)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45711 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8019-t6799-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

[LL]Trillian test result (tid-6798)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 50709 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8019-t6798-vmware-67u3.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

[LL]Trillian test result (tid-6797)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52420 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8019-t6797-xenserver-71.zip
Smoke tests completed. 105 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_query_async_job_result Error 0.00 test_async_job.py
test_02_upgrade_kubernetes_cluster Failure 730.92 test_kubernetes_clusters.py
ContextSuite context=TestDomainsServiceOfferings>:setup Error 3.46 test_domain_service_offerings.py

@DaanHoogland
Copy link
Contributor

@blueorangutan LLtest rocky8 xenserver-71

@blueorangutan
Copy link

@DaanHoogland [LL] unsupported parameters provided. Supported mgmt server os are: centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82

@DaanHoogland
Copy link
Contributor

@blueorangutan LLtest rocky8 xenserver-74

@blueorangutan
Copy link

@DaanHoogland a [LL] Trillian-Jenkins test job (rocky8 mgmt + xenserver-74) has been kicked to run smoke tests

@blueorangutan
Copy link

[LL] Trillian Build Failed (tid-6809)

@DaanHoogland
Copy link
Contributor

@blueorangutan LLtest rocky8 xcpng82

@blueorangutan
Copy link

@DaanHoogland a [LL] Trillian-Jenkins test job (rocky8 mgmt + xcpng82) has been kicked to run smoke tests

@blueorangutan
Copy link

[LL] Trillian Build Failed (tid-6810)

@DaanHoogland
Copy link
Contributor

@blueorangutan test rocky8 xenserver-74

@blueorangutan
Copy link

@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + xenserver-74) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-7908)
Environment: xenserver-74 (x2), Advanced Networking with Mgmt server r8
Total time taken: 53657 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8019-t7908-xenserver-74.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_list_volumes_metrics_history Failure 195.87 test_metrics_api.py
test_13_migrate_volume_and_change_offering Error 7.46 test_volumes.py

@blueorangutan
Copy link

[LL] Trillian Build Failed (tid-6821)

@blueorangutan
Copy link

[LL] Trillian Build Failed (tid-6825)

@blueorangutan
Copy link

[LL]Trillian test result (tid-6822)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server r8
Total time taken: 53863 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8019-t6822-xcpng82.zip
Smoke tests completed. 105 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_non_strict_host_anti_affinity Error 173.33 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 127.52 test_nonstrict_affinity_group.py
test_deploy_vm_with_registered_userdata Error 785.73 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow Error 766.34 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append Error 772.82 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params Error 765.50 test_register_userdata.py
test_list_volumes_metrics_history Failure 174.09 test_metrics_api.py

@DaanHoogland
Copy link
Contributor

last run:

Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_list_volumes_metrics_history | `Failure` | 172.00 | test_metrics_api.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 447.10 | test_vpc_redundant.py

the only persistent failure seems to be test_list_volumes_metrics_history, and only on xen.

@DaanHoogland
Copy link
Contributor

insanity:
@blueorangutan LLtest matrix

@blueorangutan
Copy link

@DaanHoogland a [LL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[LL] Trillian Build Failed (tid-6834)

@blueorangutan
Copy link

[LL]Trillian test result (tid-6835)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49316 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8019-t6835-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit 0b3438b into 4.18 Oct 16, 2023
50 checks passed
@DaanHoogland DaanHoogland deleted the 4.18-reflections-update branch October 16, 2023 07:02
DaanHoogland added a commit that referenced this pull request Oct 16, 2023
@DaanHoogland
Merge release branch 4.18 to main
314537a 
* 4.18:
  Update pom.xml reflections version (#8019)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weizhouapache weizhouapache weizhouapache approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

Assignees
No one assigned
Labels
component:build
Projects
None yet
Milestone
4.19.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mlsorensen @harikrishna-patnala @blueorangutan @DaanHoogland @rohityadavcloud @shwstppr @weizhouapache