Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log sanitation on output of jobs #8890

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

DaanHoogland
Copy link
Contributor

Description

This PR...

Fixes: #8853

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 15.04%. Comparing base (cadbb56) to head (8c7c62e).
Report is 88 commits behind head on main.

❗ Current head 8c7c62e differs from pull request most recent head ef09e5b. Consider uploading reports for the commit ef09e5b to get more accurate results

Files Patch % Lines
.../storage/resource/NfsSecondaryStorageResource.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8890      +/-   ##
============================================
- Coverage     15.13%   15.04%   -0.10%     
+ Complexity    13469    12899     -570     
============================================
  Files          4863     4881      +18     
  Lines        326031   327172    +1141     
  Branches      45838    46237     +399     
============================================
- Hits          49349    49222     -127     
- Misses       270066   271220    +1154     
- Partials       6616     6730     +114     
Flag Coverage Δ
simulator-marvin-tests 15.04% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9323

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test alma9 kvm-alma9

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

Copy link
Collaborator

@hsato03 hsato03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blueorangutan
Copy link

[SF] Trillian test result (tid-9918)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 59060 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8890-t9918-kvm-alma9.zip
Smoke tests completed. 126 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 324.55 test_events_resource.py
test_01_events_resource Error 324.57 test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Failure 109.22 test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown Error 1.55 test_network_permissions.py
test_01_vpc_site2site_vpn Failure 361.85 test_vpc_vpn.py

@DaanHoogland DaanHoogland force-pushed the ghi8853-logSanitation branch from 8c7c62e to ef09e5b Compare April 20, 2024 07:39
@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9345

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-9943)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45141 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8890-t9943-kvm-centos7.zip
Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 300.34 test_events_resource.py
test_01_events_resource Error 300.35 test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Failure 91.74 test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown Error 1.36 test_network_permissions.py

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland DaanHoogland merged commit 865da73 into apache:main Apr 23, 2024
5 of 24 checks passed
@DaanHoogland DaanHoogland deleted the ghi8853-logSanitation branch April 23, 2024 10:19
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
@DaanHoogland DaanHoogland added this to the 4.20.0.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The sensitive information of uri may leak
5 participants