Fix: Update rootdisksize detail on restore VM

[vishesh92]

Description

This PR fixes the below issue:

1. Register two VM templates, small and large.
2. Deploy VM using smaller template while overriding the rootdisksize
3. Start VM if not started
4. Stop VM
5. Reinstall VM to larger VM template
6. Observe new root is the size of old volume. This is happening because the rootdisksize detail for VM overrides the template's size.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 14.96%. Comparing base (e409c6d) to head (948508e).

Files	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	16 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.19    #8981    +/-   ##
==========================================
  Coverage     14.96%   14.96%            
- Complexity    10995    10996     +1     
==========================================
  Files          5373     5373            
  Lines        468989   469000    +11     
  Branches      61009    60655   -354     
==========================================
+ Hits          70191    70205    +14     
+ Misses       391019   391011     -8     
- Partials       7779     7784     +5     

Flag	Coverage Δ
uitests	4.31% <ø> (ø)
unittests	15.67% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sureshanaparti]

clgtm

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9433

[borisstoyanov]

@blueorangutan test keepEnv

[blueorangutan]

@borisstoyanov a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-10049)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44709 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8981-t10049-kvm-centos7.zip
Smoke tests completed. 129 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	411.42	test_events_resource.py

[borisstoyanov]

LGTM