xenserver: do not destroy halted hypervisor vm #9175

shwstppr · 2024-06-05T11:47:19Z

Description

CloudStack Xenserver hypervisor plugin calls VM.destroy when the VM is stopped or found in Halted state. This PR prevents this destroy action during VM stop or other actions like snapshot. VM.destroy is already called during the execution of the start VM action which should take care of any storage, network device changes.

TBD: Whether this behavioural change should be controlled by a global configuration?

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Deploy a VM
Take a VM snapshot
Revert snapshot (This fails as VM is in running state)
Stop the VM
Revert snapshot (successful)

(localcloud) 🐱 > deploy virtualmachine zoneid=87ab94de-5701-4aa0-8253-fcefac217440 serviceofferingid=51ac121c-987b-446b-9e51-a383f30f8156 templateid=a698f5ea-e51a-403c-a7be-22d5f6eaa11b networkids=73a2e297-15b3-4237-b76a-12606799c055 
{
  "virtualmachine": {
    "account": "admin",
    "affinitygroup": [],
    "cpunumber": 1,
    "cpuspeed": 500,
    "created": "2024-06-05T11:39:39+0000",
    "details": {
      "cpuOvercommitRatio": "2.0",
      "hypervisortoolsversion": "false",
      "memoryOvercommitRatio": "1.0"
    },
    "displayname": "VM-81c37009-0289-4a22-84ad-1a661d7c8374",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "5a4b4766-1e62-11ef-b827-1e00120002d6",
    "guestosid": "8170a0ea-d54d-4cb9-b6a6-9d7652960164",
    "haenable": false,
    "hasannotations": false,
    "hostcontrolstate": "Enabled",
    "hostid": "19ccfbce-b0c5-4c85-a176-423d5eec70c1",
    "hostname": "ref-trl-6722-x-M7-abhishek-kumar-xs2",
    "hypervisor": "XenServer",
    "id": "81c37009-0289-4a22-84ad-1a661d7c8374",
    "instancename": "i-2-7-VM",
    "isdynamicallyscalable": false,
    "jobid": "31c96eca-fff7-4258-8a98-d3c45abf424d",
    "jobstatus": 0,
    "lastupdated": "2024-06-05T11:39:50+0000",
    "memory": 512,
    "name": "VM-81c37009-0289-4a22-84ad-1a661d7c8374",
    "nic": [
      {
        "broadcasturi": "vlan://2144",
        "deviceid": "0",
        "extradhcpoption": [],
        "id": "fe0db5bf-1903-447c-abc5-c3978b0f4ff4",
        "isdefault": true,
        "isolationuri": "vlan://2144",
        "macaddress": "02:01:00:cc:00:03",
        "networkid": "73a2e297-15b3-4237-b76a-12606799c055",
        "networkname": "test",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "L2"
      }
    ],
    "osdisplayname": "Debian GNU/Linux 12 (64-bit)",
    "ostypeid": "8170a0ea-d54d-4cb9-b6a6-9d7652960164",
    "passwordenabled": false,
    "pooltype": "NetworkFilesystem",
    "receivedbytes": 0,
    "rootdeviceid": 0,
    "rootdevicetype": "ROOT",
    "securitygroup": [],
    "sentbytes": 0,
    "serviceofferingid": "51ac121c-987b-446b-9e51-a383f30f8156",
    "serviceofferingname": "Small Instance",
    "state": "Running",
    "tags": [],
    "templatedisplaytext": "debian12-dummy",
    "templateformat": "VHD",
    "templateid": "a698f5ea-e51a-403c-a7be-22d5f6eaa11b",
    "templatename": "debian12-dummy",
    "templatetype": "USER",
    "userid": "78617ce4-1e62-11ef-b827-1e00120002d6",
    "username": "admin",
    "zoneid": "87ab94de-5701-4aa0-8253-fcefac217440",
    "zonename": "ref-trl-6722-x-M7-abhishek-kumar"
  }
}
(localcloud) 🐱 > create vmsnapshot virtualmachineid=81c37009-0289-4a22-84ad-1a661d7c8374 
{
  "vmsnapshot": {
    "account": "admin",
    "created": "2024-06-05T11:40:21+0000",
    "current": true,
    "displayname": "i-2-7-VM_VS_20240605114021",
    "domain": "ROOT",
    "domainid": "5a4b4766-1e62-11ef-b827-1e00120002d6",
    "hasannotations": false,
    "hypervisor": "XenServer",
    "id": "d71892db-5d97-49ba-8d54-98f724dc5630",
    "name": "i-2-7-VM_VS_20240605114021",
    "state": "Ready",
    "tags": [],
    "type": "Disk",
    "virtualmachineid": "81c37009-0289-4a22-84ad-1a661d7c8374",
    "virtualmachinename": "VM-81c37009-0289-4a22-84ad-1a661d7c8374",
    "zoneid": "87ab94de-5701-4aa0-8253-fcefac217440",
    "zonename": "ref-trl-6722-x-M7-abhishek-kumar"
  }
}
(localcloud) 🐱 > revert tovmsnapshot vmsnapshotid=d71892db-5d97-49ba-8d54-98f724dc5630
{
  "account": "admin",
  "accountid": "785ffbf6-1e62-11ef-b827-1e00120002d6",
  "cmd": "org.apache.cloudstack.api.command.admin.vmsnapshot.RevertToVMSnapshotCmdByAdmin",
  "completed": "2024-06-05T11:42:16+0000",
  "created": "2024-06-05T11:42:16+0000",
  "domainid": "5a4b4766-1e62-11ef-b827-1e00120002d6",
  "domainpath": "ROOT",
  "jobid": "f8fb0cf5-ce67-4e44-86e9-5777a1d1aaca",
  "jobinstancetype": "VmSnapshot",
  "jobprocstatus": 0,
  "jobresult": {
    "errorcode": 431,
    "errortext": "VM Snapshot revert not allowed. This will result in VM state change. You can revert running VM to disk and memory type snapshot and stopped VM to disk type snapshot"
  },
  "jobresultcode": 431,
  "jobresulttype": "object",
  "jobstatus": 2,
  "userid": "78617ce4-1e62-11ef-b827-1e00120002d6"
}
🙈 Error: async API failed for job f8fb0cf5-ce67-4e44-86e9-5777a1d1aaca
(localcloud) 🐱 > stop virtualmachine id=81c37009-0289-4a22-84ad-1a661d7c8374 forced=true 
{
  "virtualmachine": {
    "account": "admin",
    "affinitygroup": [],
    "cpunumber": 1,
    "cpuspeed": 500,
    "cpuused": "2%",
    "created": "2024-06-05T11:39:39+0000",
    "details": {
      "Message.ReservedCapacityFreed.Flag": "false",
      "cpuOvercommitRatio": "2.0",
      "hypervisortoolsversion": "xenserver56",
      "memoryOvercommitRatio": "1.0",
      "platform": "device-model:qemu-upstream-compat;apic:true;viridian:true;timeoffset:0;pae:true;acpi:1;hpet:true;secureboot:false;nx:true"
    },
    "diskioread": 0,
    "diskiowrite": 0,
    "diskkbsread": 119,
    "diskkbswrite": 3,
    "displayname": "VM-81c37009-0289-4a22-84ad-1a661d7c8374",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "5a4b4766-1e62-11ef-b827-1e00120002d6",
    "guestosid": "8170a0ea-d54d-4cb9-b6a6-9d7652960164",
    "haenable": false,
    "hasannotations": false,
    "hypervisor": "XenServer",
    "id": "81c37009-0289-4a22-84ad-1a661d7c8374",
    "instancename": "i-2-7-VM",
    "isdynamicallyscalable": false,
    "jobid": "75ae73fb-f917-45f7-907e-0fa5ce956b33",
    "jobstatus": 0,
    "lastupdated": "2024-06-05T11:42:41+0000",
    "memory": 512,
    "memoryintfreekbs": 0,
    "memorykbs": 524284,
    "memorytargetkbs": 524288,
    "name": "VM-81c37009-0289-4a22-84ad-1a661d7c8374",
    "networkkbsread": 0,
    "networkkbswrite": 0,
    "nic": [
      {
        "deviceid": "0",
        "extradhcpoption": [],
        "id": "fe0db5bf-1903-447c-abc5-c3978b0f4ff4",
        "isdefault": true,
        "macaddress": "02:01:00:cc:00:03",
        "networkid": "73a2e297-15b3-4237-b76a-12606799c055",
        "networkname": "test",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "L2"
      }
    ],
    "osdisplayname": "Debian GNU/Linux 12 (64-bit)",
    "ostypeid": "8170a0ea-d54d-4cb9-b6a6-9d7652960164",
    "passwordenabled": false,
    "pooltype": "NetworkFilesystem",
    "receivedbytes": 0,
    "rootdeviceid": 0,
    "rootdevicetype": "ROOT",
    "securitygroup": [],
    "sentbytes": 0,
    "serviceofferingid": "51ac121c-987b-446b-9e51-a383f30f8156",
    "serviceofferingname": "Small Instance",
    "state": "Stopped",
    "tags": [],
    "templatedisplaytext": "debian12-dummy",
    "templateformat": "VHD",
    "templateid": "a698f5ea-e51a-403c-a7be-22d5f6eaa11b",
    "templatename": "debian12-dummy",
    "templatetype": "USER",
    "userid": "78617ce4-1e62-11ef-b827-1e00120002d6",
    "username": "admin",
    "zoneid": "87ab94de-5701-4aa0-8253-fcefac217440",
    "zonename": "ref-trl-6722-x-M7-abhishek-kumar"
  }
}
(localcloud) 🐱 > revert tovmsnapshot vmsnapshotid=d71892db-5d97-49ba-8d54-98f724dc5630
{
  "virtualmachine": {
    "account": "admin",
    "affinitygroup": [],
    "cpunumber": 1,
    "cpuspeed": 500,
    "cpuused": "2%",
    "created": "2024-06-05T11:39:39+0000",
    "details": {
      "Message.ReservedCapacityFreed.Flag": "false",
      "cpuOvercommitRatio": "2.0",
      "hypervisortoolsversion": "xenserver56",
      "memoryOvercommitRatio": "1.0",
      "platform": "device-model:qemu-upstream-compat;apic:true;viridian:true;timeoffset:0;pae:true;acpi:1;hpet:true;secureboot:false;nx:true"
    },
    "diskioread": 0,
    "diskiowrite": 0,
    "diskkbsread": 119,
    "diskkbswrite": 3,
    "displayname": "VM-81c37009-0289-4a22-84ad-1a661d7c8374",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "5a4b4766-1e62-11ef-b827-1e00120002d6",
    "guestosid": "8170a0ea-d54d-4cb9-b6a6-9d7652960164",
    "haenable": false,
    "hasannotations": false,
    "hypervisor": "XenServer",
    "id": "81c37009-0289-4a22-84ad-1a661d7c8374",
    "instancename": "i-2-7-VM",
    "isdynamicallyscalable": false,
    "lastupdated": "2024-06-05T11:42:41+0000",
    "memory": 512,
    "memoryintfreekbs": 0,
    "memorykbs": 524284,
    "memorytargetkbs": 524288,
    "name": "VM-81c37009-0289-4a22-84ad-1a661d7c8374",
    "networkkbsread": 0,
    "networkkbswrite": 0,
    "nic": [
      {
        "deviceid": "0",
        "extradhcpoption": [],
        "id": "fe0db5bf-1903-447c-abc5-c3978b0f4ff4",
        "isdefault": true,
        "macaddress": "02:01:00:cc:00:03",
        "networkid": "73a2e297-15b3-4237-b76a-12606799c055",
        "networkname": "test",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "L2"
      }
    ],
    "osdisplayname": "Debian GNU/Linux 12 (64-bit)",
    "ostypeid": "8170a0ea-d54d-4cb9-b6a6-9d7652960164",
    "passwordenabled": false,
    "pooltype": "NetworkFilesystem",
    "receivedbytes": 0,
    "rootdeviceid": 0,
    "rootdevicetype": "ROOT",
    "securitygroup": [],
    "sentbytes": 0,
    "serviceofferingid": "51ac121c-987b-446b-9e51-a383f30f8156",
    "serviceofferingname": "Small Instance",
    "state": "Stopped",
    "tags": [],
    "templatedisplaytext": "debian12-dummy",
    "templateformat": "VHD",
    "templateid": "a698f5ea-e51a-403c-a7be-22d5f6eaa11b",
    "templatename": "debian12-dummy",
    "templatetype": "USER",
    "userid": "78617ce4-1e62-11ef-b827-1e00120002d6",
    "username": "admin",
    "zoneid": "87ab94de-5701-4aa0-8253-fcefac217440",
    "zonename": "ref-trl-6722-x-M7-abhishek-kumar"

How did you try to break this feature and the system with this change?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2024-06-05T11:52:55Z

@blueorangutan package

blueorangutan · 2024-06-05T11:54:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-06-05T11:55:18Z

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (54c8b71) to head (c80ffea).

Files	Patch %	Lines
...ervisor/xenserver/resource/CitrixResourceBase.java	0.00%	19 Missing ⚠️
.../xenbase/CitrixCreateVMSnapshotCommandWrapper.java	0.00%	3 Missing and 1 partial ⚠️
...enbase/CitrixRevertToVMSnapshotCommandWrapper.java	0.00%	2 Missing ⚠️
.../wrapper/xen56/XenServer56FenceCommandWrapper.java	0.00%	1 Missing ⚠️
...per/xen56p1/XenServer56FP1FenceCommandWrapper.java	0.00%	1 Missing ⚠️
.../xenbase/CitrixDeleteVMSnapshotCommandWrapper.java	0.00%	1 Missing ⚠️
...rce/wrapper/xenbase/CitrixStartCommandWrapper.java	0.00%	1 Missing ⚠️
...urce/wrapper/xenbase/CitrixStopCommandWrapper.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.19    #9175    +/-   ##
==========================================
  Coverage     15.07%   15.08%            
- Complexity    11169    11173     +4     
==========================================
  Files          5405     5405            
  Lines        472677   472692    +15     
  Branches      60049    59523   -526     
==========================================
+ Hits          71269    71283    +14     
- Misses       393479   393480     +1     
  Partials       7929     7929

Flag	Coverage Δ
uitests	`4.27% <ø> (ø)`
unittests	`15.79% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-06-05T13:04:30Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9794

shwstppr · 2024-06-26T06:58:38Z

Will run a round of tests here. Though I didn't see any issue in my manual testing but I'm not sure if not destroying a halted VM from hypervisor side can lead to any regressions cc @sureshanaparti @harikrishna-patnala

@blueorangutan package

blueorangutan · 2024-06-26T07:00:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-26T08:04:31Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10139

sureshanaparti · 2024-06-26T08:20:01Z

@blueorangutan test rocky8 xcpng82

blueorangutan · 2024-06-26T08:22:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (rocky8 mgmt + xcpng82) has been kicked to run smoke tests

blueorangutan · 2024-06-27T02:58:01Z

[SF] Trillian test result (tid-10635)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server r8
Total time taken: 65281 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9175-t10635-xcpng82.zip
Smoke tests completed. 111 look OK, 20 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestTemplateHierarchy>:setup	`Error`	10.03	test_accounts.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup	`Error`	0.00	test_affinity_groups.py
ContextSuite context=TestDummyBackupAndRecovery>:setup	`Error`	0.00	test_backup_recovery_dummy.py
ContextSuite context=TestVeeamBackupAndRecovery>:setup	`Error`	0.00	test_backup_recovery_veeam.py
test_01_condensed_drs_algorithm	`Error`	0.00	test_cluster_drs.py
test_02_balanced_drs_algorithm	`Error`	0.00	test_cluster_drs.py
ContextSuite context=TestConsoleEndpoint>:setup	`Error`	0.00	test_console_endpoint.py
test_06_deploy_vm_with_extraconfig_throws_exception_xenserver	`Error`	0.10	test_deploy_vm_extra_config_data.py
test_07_deploy_vm_with_extraconfig_xenserver	`Error`	0.09	test_deploy_vm_extra_config_data.py
ContextSuite context=TestDeployVmRootSize>:setup	`Error`	0.00	test_deploy_vm_root_resize.py
ContextSuite context=TestHostControlState>:setup	`Error`	0.06	test_host_control_state.py
test_02_upgrade_kubernetes_cluster	`Failure`	493.68	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	`Error`	3.32	test_kubernetes_clusters.py
ContextSuite context=TestSharedNetwork>:setup	`Error`	99.22	test_network.py
test_01_non_strict_host_anti_affinity	`Error`	1.17	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	2.21	test_nonstrict_affinity_group.py
ContextSuite context=TestL2PersistentNetworks>:setup	`Error`	0.00	test_persistent_network.py
ContextSuite context=TestPrivateGwACLOvsGRE>:setup	`Error`	0.00	test_privategw_acl_ovs_gre.py
ContextSuite context=TestTemplates>:setup	`Error`	0.13	test_templates.py
test_01_positive_tests_usage	`Failure`	3.58	test_usage_events.py
ContextSuite context=TestVmAutoScaling>:setup	`Error`	0.00	test_vm_autoscaling.py
test_01_deploy_vm_on_specific_host	`Error`	0.06	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	0.04	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	0.08	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	0.10	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	0.07	test_vm_deployment_planner.py
ContextSuite context=TestVMSchedule>:setup	`Error`	0.00	test_vm_schedule.py
ContextSuite context=TestVnfTemplates>:setup	`Error`	0.00	test_vnf_templates.py

sureshanaparti · 2024-06-27T05:44:46Z

@blueorangutan test rocky8 xcpng82

blueorangutan · 2024-06-27T05:46:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (rocky8 mgmt + xcpng82) has been kicked to run smoke tests

shwstppr · 2024-06-27T11:10:00Z

@blueorangutan package

blueorangutan · 2024-06-27T11:12:05Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-27T12:19:13Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10164

blueorangutan · 2024-06-27T23:53:20Z

[SF] Trillian test result (tid-10647)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server r8
Total time taken: 63680 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9175-t10647-xcpng82.zip
Smoke tests completed. 110 look OK, 21 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestTemplateHierarchy>:setup	`Error`	10.10	test_accounts.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup	`Error`	0.00	test_affinity_groups.py
ContextSuite context=TestDummyBackupAndRecovery>:setup	`Error`	0.00	test_backup_recovery_dummy.py
ContextSuite context=TestVeeamBackupAndRecovery>:setup	`Error`	0.00	test_backup_recovery_veeam.py
test_01_condensed_drs_algorithm	`Error`	0.00	test_cluster_drs.py
test_02_balanced_drs_algorithm	`Error`	0.00	test_cluster_drs.py
ContextSuite context=TestConsoleEndpoint>:setup	`Error`	0.00	test_console_endpoint.py
test_06_deploy_vm_with_extraconfig_throws_exception_xenserver	`Error`	0.09	test_deploy_vm_extra_config_data.py
test_07_deploy_vm_with_extraconfig_xenserver	`Error`	0.07	test_deploy_vm_extra_config_data.py
ContextSuite context=TestDeployVmRootSize>:setup	`Error`	0.00	test_deploy_vm_root_resize.py
ContextSuite context=TestHostControlState>:setup	`Error`	0.05	test_host_control_state.py
test_11_test_unmanaged_cluster_lifecycle	`Error`	1.28	test_kubernetes_clusters.py
ContextSuite context=TestSharedNetwork>:setup	`Error`	94.33	test_network.py
test_01_non_strict_host_anti_affinity	`Error`	2.19	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	2.21	test_nonstrict_affinity_group.py
ContextSuite context=TestL2PersistentNetworks>:setup	`Error`	0.00	test_persistent_network.py
ContextSuite context=TestPrivateGwACLOvsGRE>:setup	`Error`	0.00	test_privategw_acl_ovs_gre.py
ContextSuite context=TestTemplates>:setup	`Error`	0.13	test_templates.py
test_01_positive_tests_usage	`Failure`	3.45	test_usage_events.py
ContextSuite context=TestVmAutoScaling>:setup	`Error`	0.00	test_vm_autoscaling.py
test_01_deploy_vm_on_specific_host	`Error`	0.05	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	0.04	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	0.07	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	0.09	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	0.06	test_vm_deployment_planner.py
ContextSuite context=TestVMSchedule>:setup	`Error`	0.00	test_vm_schedule.py
ContextSuite context=TestVnfTemplates>:setup	`Error`	0.00	test_vnf_templates.py
test_01_vpc_site2site_vpn_multiple_options	`Failure`	620.89	test_vpc_vpn.py

shwstppr · 2024-06-28T04:14:47Z

Looks like changes behaviour is causing issues. I'll investigate further. This can be moved out of the 4.19.1 milestone. We already have a workaround for #8123 by adding the newer guest OS(es).

shwstppr · 2024-07-22T06:47:25Z

@blueorangutan package

blueorangutan · 2024-07-22T06:48:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-07-22T08:08:53Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10428

shwstppr added 3 commits June 3, 2024 14:55

TEST - xenserver: don't destroy halted vms

b3d48f3

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

fix

c7035bc

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

remove unused

37c4873

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborg bot added the component:XenServer label Jun 5, 2024

shwstppr mentioned this pull request Jun 5, 2024

Cannot restore VM snapshot on XenServer #8123

Open

rohityadavcloud modified the milestones: 4.19.2.0, 4.19.1.0 Jun 24, 2024

Merge branch '4.19' into fix-xen-stopvmdestroy

5dd6b3d

Merge branch '4.19' into fix-xen-stopvmdestroy

77f946c

shwstppr changed the title ~~[DRAFT] xenserver: do not destroy halted hypervisor vm~~ xenserver: do not destroy halted hypervisor vm Jun 27, 2024

sureshanaparti modified the milestones: 4.19.1.0, 4.19.2.0 Jun 28, 2024

shwstppr added 2 commits July 2, 2024 11:53

Merge branch '4.19' into fix-xen-stopvmdestroy

efdd571

Merge branch '4.19' into fix-xen-stopvmdestroy

c80ffea

DaanHoogland linked an issue Nov 8, 2024 that may be closed by this pull request

Cannot restore VM snapshot on XenServer #8123

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

xenserver: do not destroy halted hypervisor vm #9175

xenserver: do not destroy halted hypervisor vm #9175

shwstppr commented Jun 5, 2024 •

edited by DaanHoogland

Loading

shwstppr commented Jun 5, 2024

blueorangutan commented Jun 5, 2024

codecov bot commented Jun 5, 2024 •

edited

Loading

blueorangutan commented Jun 5, 2024

shwstppr commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

sureshanaparti commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

blueorangutan commented Jun 27, 2024

sureshanaparti commented Jun 27, 2024

blueorangutan commented Jun 27, 2024

shwstppr commented Jun 27, 2024

blueorangutan commented Jun 27, 2024

blueorangutan commented Jun 27, 2024

blueorangutan commented Jun 27, 2024

shwstppr commented Jun 28, 2024

shwstppr commented Jul 22, 2024

blueorangutan commented Jul 22, 2024

blueorangutan commented Jul 22, 2024

xenserver: do not destroy halted hypervisor vm #9175

Are you sure you want to change the base?

xenserver: do not destroy halted hypervisor vm #9175

Conversation

shwstppr commented Jun 5, 2024 • edited by DaanHoogland Loading

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

shwstppr commented Jun 5, 2024

blueorangutan commented Jun 5, 2024

codecov bot commented Jun 5, 2024 • edited Loading

Codecov Report

blueorangutan commented Jun 5, 2024

shwstppr commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

sureshanaparti commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

blueorangutan commented Jun 27, 2024

sureshanaparti commented Jun 27, 2024

blueorangutan commented Jun 27, 2024

shwstppr commented Jun 27, 2024

blueorangutan commented Jun 27, 2024

blueorangutan commented Jun 27, 2024

blueorangutan commented Jun 27, 2024

shwstppr commented Jun 28, 2024

shwstppr commented Jul 22, 2024

blueorangutan commented Jul 22, 2024

blueorangutan commented Jul 22, 2024

shwstppr commented Jun 5, 2024 •

edited by DaanHoogland

Loading

codecov bot commented Jun 5, 2024 •

edited

Loading