Add support for functionality in hypervisor class

[vishesh92]

Description

This PR adds support for functionality in hypervisor class. This solves 2 issues:

1. Allow configuring supported functionality of a hypervisor in Hypervisor class itself and remove custom logic of different hypervisors in the code. For now, we are only functionalities. Rest can be added later.
2. This allows custom hypervisor plugins to define their supported functionalities as well.

Types of changes

• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 45.71429% with 19 lines in your changes missing coverage. Please review.

Project coverage is 15.78%. Comparing base (bf2cede) to head (de41a6f).
Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	10.00%	9 Missing ⚠️
...src/main/java/com/cloud/hypervisor/Hypervisor.java	68.18%	7 Missing ⚠️
...api/command/user/template/RegisterTemplateCmd.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               main    #9736    +/-   ##
==========================================
  Coverage     15.78%   15.78%            
- Complexity    12550    12552     +2     
==========================================
  Files          5625     5625            
  Lines        491958   492012    +54     
  Branches      60504    60273   -231     
==========================================
+ Hits          77663    77674    +11     
- Misses       405836   405878    +42     
- Partials       8459     8460     +1     

Flag	Coverage Δ
uitests	4.03% <ø> (-0.01%)	⬇️
unittests	16.60% <45.71%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11213

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11233

[vishesh92]

@blueorangutan test matrix

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11576)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54729 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9736-t11576-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestISOUsage>:setup	Error	0.00	test_usage.py

[blueorangutan]

[SF] Trillian test result (tid-11577)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 58863 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9736-t11577-kvm-ubuntu22.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestISOUsage>:setup	Error	0.00	test_usage.py
test_hostha_enable_ha_when_host_disabled	Error	3.96	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	Error	305.15	test_hostha_kvm.py

[shwstppr]

Code LGTM

[sureshanaparti]

clgtm

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11267

[vishesh92]

@blueorangutan test

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11606)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 73371 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9736-t11606-kvm-ol8.zip
Smoke tests completed. 137 look OK, 3 have errors, 1 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	Failure	0.03	test_ssvm.py
test_04_cpvm_internals	Failure	0.04	test_ssvm.py
test_01_secure_vm_migration	Error	305.98	test_vm_life_cycle.py
test_02_unsecure_vm_migration	Error	352.50	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	Error	356.25	test_vm_life_cycle.py
test_hostha_configure_default_driver	Error	365.95	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	Failure	855.46	test_hostha_kvm.py
test_hostha_kvm_host_degraded	Error	1982.62	test_hostha_kvm.py
test_hostha_kvm_host_degraded	Error	1982.62	test_hostha_kvm.py
test_hostha_kvm_host_recovering	Error	193.74	test_hostha_kvm.py
test_remove_ha_provider_not_possible	Error	277.00	test_hostha_kvm.py
all_test_host_maintenance	Skipped	---	test_host_maintenance.py

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11303

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11642)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 76268 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9736-t11642-kvm-ol8.zip
Smoke tests completed. 133 look OK, 2 have errors, 6 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	Error	134.17	test_vm_life_cycle.py
test_01_secure_vm_migration	Error	134.17	test_vm_life_cycle.py
test_04_rvpc_network_garbage_collector_nics	Error	2466.66	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	Error	2466.67	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Error	55.13	test_vpc_redundant.py
ContextSuite context=TestVPCRedundancy>:teardown	Error	116.66	test_vpc_redundant.py
all_test_vpc_router_nics	Skipped	---	test_vpc_router_nics.py
all_test_vpc_vpn	Skipped	---	test_vpc_vpn.py
all_test_webhook_delivery	Skipped	---	test_webhook_delivery.py
all_test_webhook_lifecycle	Skipped	---	test_webhook_lifecycle.py
all_test_host_maintenance	Skipped	---	test_host_maintenance.py
all_test_hostha_kvm	Skipped	---	test_hostha_kvm.py