Fix updateTemplatePermission when the UI is set to a language other than English
#9766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelipeM525
approved these changes
Oct 3, 2024
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9766 +/- ##
============================================
- Coverage 15.78% 15.78% -0.01%
- Complexity 12551 12552 +1
============================================
Files 5625 5625
Lines 491993 491993
Branches 59773 62600 +2827
============================================
- Hits 77670 77668 -2
Misses 405864 405864
- Partials 8459 8461 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
|
tried in qa; Dutch and Protugese, both work. |
FelipeM525
approved these changes
Oct 4, 2024
weizhouapache
pushed a commit
that referenced
this pull request
Oct 15, 2024
… than English (#9766) * Fix updateTemplatePermission UI in non-english language * Improve fix --------- Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the UI is set to a language other than English, the update template permissions feature throws an exception. This PR fixes this behavior to allow updating template permissions when using the UI in any language.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
Before changes
After changes
How Has This Been Tested?
Using a private template, I tested the
Add,Remove, andResetpermission operations in a UI set to several non-English languages.