BCEL-363 Enforce MAX_CP_ENTRIES in ConstantPoolGen and ConstantPool.dump #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garydgregory
requested changes
Sep 20, 2022
There was a problem hiding this comment.
Hello @rjatkins
Thank you for your PR.
You'll need to add tests to this PR, otherwise, this will be a regression waiting to happen.
|
I've added the requested test coverage. Let me know if you need further changes |
|
@rjatkins merged, ty for your PR! |
|
@garydgregory is there any chance of a release with this fix in it soon? I'd like to use it to patch xalan, and I'd rather not have to release a patched version of BCEL to do it. |
|
@rjatkins |
kriegaex
added a commit
to eclipse-aspectj/aspectj
that referenced
this pull request
Nov 13, 2022
Fixes #192. See GHSA-97xg-phpr-rg8q. See https://issues.apache.org/jira/browse/BCEL-363. See apache/commons-bcel#147. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
kriegaex
added a commit
to eclipse-aspectj/aspectj
that referenced
this pull request
Nov 13, 2022
Fixes #192. See GHSA-97xg-phpr-rg8q. See https://issues.apache.org/jira/browse/BCEL-363. See apache/commons-bcel#147. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapplies the fix in openjdk/jdk11u@13bf52c but using the Const constant for the constant pool size limit.