Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update methods encodeHex and decodeHex to simplify the code and make it slightly more efficient.
encodeHex: don't compute dataOffset + dataLen on every for iteration and also standardize nibble high and low using Base16.encode() as inspiration. I would say it's easier to read now.
decodeHex: get high and low nibble directly using for loop iterator incrementing by 2 (2 char per hex val) and OR them immediately instead of getting high nibble, iterating variable, ORing low nibble, iterating variable then converting to byte. I think it's far more readable this way.
I tested both with a barebones jmh benchmark and speed is roughly the same or very slightly faster than old implementation for both.