[IMAGING-355] Add option to skip reading GIF metadata #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
============================================
+ Coverage 70.82% 71.45% +0.63%
- Complexity 3405 3569 +164
============================================
Files 333 352 +19
Lines 16834 17375 +541
Branches 2588 2694 +106
============================================
+ Hits 11922 12415 +493
- Misses 3897 3906 +9
- Partials 1015 1054 +39 ☔ View full report in Codecov by Sentry. |
kinow
reviewed
Jul 9, 2023
src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
Outdated
Show resolved
Hide resolved
…adata * Add stopReadingBeforeImageData to GifImageParameters * Add unit test for IMAGING-355
|
@garydgregory and @kinow I implemented the changes per your request. However, I am not sure how much value passing stopReadinngBeforeImageData via GifImageParameters adds.
|
| @@ -407,7 +407,11 @@ public byte[] getIccProfileBytes(final ByteSource byteSource, final GifImagingPa | |||
| @Override | |||
| public ImageInfo getImageInfo(final ByteSource byteSource, final GifImagingParameters params) | |||
| throws ImagingException, IOException { | |||
| final GifImageContents blocks = readFile(byteSource, false); | |||
| boolean stopReadingBeforeImageData = true; | |||
There was a problem hiding this comment.
You've changed the default behavior here which makes the parameter a forced usage, which might be a surprise, I'll flip it post mege.
garydgregory
changed the title
garydgregory
changed the title
asfgit
pushed a commit
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMAGING-355 - Large animated GIF takes too much heap memory in getMetadata