Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc): Document public RandomStringUtils exploit #459

Closed
wants to merge 2 commits into from
+5 −1
Closed

(doc): Document public RandomStringUtils exploit #459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c8ea01
(doc): Document public RandomStringUtils exploit
JLLeitschuh Sep 16, 2019
5698827
(doc): Use Medium Friend link for RandomStringUtils documentation
JLLeitschuh Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/org/apache/commons/lang3/RandomStringUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@
* RandomStringGenerator</a> instead.</p>
*
* <p>Caveat: Instances of {@link Random}, upon which the implementation of this
* class relies, are not cryptographically secure.</p>
* class relies, are <b>not cryptographically secure</b>.
* Do not use this classes' default implementation of {@link Random} in security sensitive locations,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be

this class' default..

Or

These classes'

Or simply

Avoid using the default implementation in this classs if you need a cryptographically secure...

* for example password reset key generation, as all future values can be computed as proven by
* <a href="https://medium.com/@alex91ar/the-java-soothsayer-a-practical-application-for-insecure-randomness-c67b0cd148cd?source=friends_link&sk=3db1c41cc81a58f70ed05a7315191385">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with others on the issue with a link to medium, but I don't care much about monetization.

If we have a link to CVE, a paper published in some journal, a standard documentation from some site like ietf, or a wikipedia page, it would be preferrable IMHO.

If this is the only place with an explanation, or the best link to understand the issue, then we need to use a web.archive.org link to prevent it from disappearing after some years.

Copy link
Author

@JLLeitschuh JLLeitschuh Sep 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex91ar Thoughts?
I have a CVE for JHipster. That's just a specific case though. This is a full POC.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you'd like I can port the article to somewhere else, just say where and I will!

* this proof of concept.</a></p>
*
* <p>Please note that the Apache Commons project provides a component
* dedicated to pseudo-random number generation, namely
Expand Down