Skip to content

Commit

Permalink
Remove obsolete jshint comments (#444)
Browse files Browse the repository at this point in the history
  • Loading branch information
raphinesse authored and shazron committed May 21, 2018
1 parent fc69da7 commit 02ee925
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 24 deletions.
4 changes: 0 additions & 4 deletions bin/templates/cordova/lib/AndroidManifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,11 @@ AndroidManifest.prototype.setVersionCode = function (versionCode) {
};

AndroidManifest.prototype.getPackageId = function () {
/* jshint -W069 */
return this.doc.getroot().attrib['package'];
/* jshint +W069 */
};

AndroidManifest.prototype.setPackageId = function (pkgId) {
/* jshint -W069 */
this.doc.getroot().attrib['package'] = pkgId;
/* jshint +W069 */
return this;
};

Expand Down
2 changes: 0 additions & 2 deletions bin/templates/cordova/lib/AndroidStudio.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
* @param {String} root Root folder of the project
*/

/* jshint esnext: false */

module.exports.isAndroidStudioProject = function isAndroidStudioProject (root) {
return true;
};
2 changes: 0 additions & 2 deletions bin/templates/cordova/lib/builders/GenericBuilder.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,7 @@ function findOutputApksHelper (dir, build_type, arch) {
var archSpecific = !!/-x86|-arm/.exec(path.basename(ret[0]));
// And show only arch-specific ones (or non-arch-specific)
ret = ret.filter(function (p) {
/* jshint -W018 */
return !!/-x86|-arm/.exec(path.basename(p)) === archSpecific;
/* jshint +W018 */
});

if (archSpecific && ret.length > 1 && arch) {
Expand Down
2 changes: 0 additions & 2 deletions bin/templates/cordova/lib/builders/GradleBuilder.js
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,7 @@ GradleBuilder.prototype.prepEnv = function (opts) {
// If it's not set, do nothing, assuming that we're using a future version of gradle that we don't want to mess with.
// For some reason, using ^ and $ don't work. This does the job, though.
var distributionUrlRegex = /distributionUrl.*zip/;
/* jshint -W069 */
var distributionUrl = process.env['CORDOVA_ANDROID_GRADLE_DISTRIBUTION_URL'] || 'https\\://services.gradle.org/distributions/gradle-4.4-all.zip';
/* jshint +W069 */
var gradleWrapperPropertiesPath = path.join(self.root, 'gradle', 'wrapper', 'gradle-wrapper.properties');
shell.chmod('u+w', gradleWrapperPropertiesPath);
shell.sed('-i', distributionUrlRegex, 'distributionUrl=' + distributionUrl, gradleWrapperPropertiesPath);
Expand Down
2 changes: 0 additions & 2 deletions bin/templates/cordova/lib/check_reqs.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
under the License.
*/

/* jshint sub:true */

var shelljs = require('shelljs');
var child_process = require('child_process');
var Q = require('q');
Expand Down
2 changes: 0 additions & 2 deletions bin/templates/cordova/lib/emulator.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
under the License.
*/

/* jshint sub:true */

var android_versions = require('android-versions');
var retry = require('./retry');
var build = require('./build');
Expand Down
2 changes: 0 additions & 2 deletions bin/templates/cordova/lib/pluginHandlers.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
*
*/

/* jshint unused: vars */

var fs = require('fs');
var path = require('path');
var shell = require('shelljs');
Expand Down
2 changes: 0 additions & 2 deletions bin/templates/cordova/lib/retry.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
under the License.
*/

/* jshint node: true */

'use strict';

var events = require('cordova-common').events;
Expand Down
2 changes: 0 additions & 2 deletions bin/templates/cordova/lib/run.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
under the License.
*/

/* jshint loopfunc:true */

var path = require('path');
var build = require('./build');
var emulator = require('./emulator');
Expand Down
2 changes: 0 additions & 2 deletions bin/templates/project/assets/www/cordova.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
var PLATFORM_VERSION_BUILD_LABEL = '7.2.0-dev';
// file: src/scripts/require.js

/* jshint -W079 */
/* jshint -W020 */

var require;
var define;
Expand Down
2 changes: 0 additions & 2 deletions test/app/src/main/assets/www/cordova.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
var PLATFORM_VERSION_BUILD_LABEL = '6.2.0-dev';
// file: src/scripts/require.js

/*jshint -W079 */
/*jshint -W020 */

var require,
define;
Expand Down

0 comments on commit 02ee925

Please sign in to comment.