chore: improve when to display warning

apache · Jun 27, 2022 · f632d4e · f632d4e
1 parent 126b735
commit f632d4e
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/prepare.js b/lib/prepare.js
@@ -401,7 +401,10 @@ function updateProjectSplashScreen (platformConfig, locations) {
             break;
 
         case 'windowSplashScreenBrandingImage':
-            events.emit('warn', `"${themeKey}" is currently not supported by the splash screen compatibility library. https://issuetracker.google.com/issues/194301890`);
+            // display warning only when set.
+            if (cdvConfigPrefValue) {
+                events.emit('warn', `"${themeKey}" is currently not supported by the splash screen compatibility library. https://issuetracker.google.com/issues/194301890`);
+            }
 
             updateProjectSplashScreenImage(locations, themeKey, cdvConfigPrefKey, cdvConfigPrefValue);
 
@@ -547,7 +550,7 @@ function updateProjectSplashScreenImage (locations, themeKey, cdvConfigPrefKey,
         let emitType = 'verbose';
         let emmitMessage = `The "${cdvConfigPrefKey}" is undefined. Cordova's default will be used.`;
 
-        if (!fs.existsSync(cdvConfigPrefValue)) {
+        if (cdvConfigPrefValue && !fs.existsSync(cdvConfigPrefValue)) {
             emitType = 'warn';
             emmitMessage = `The "${cdvConfigPrefKey}" value does not exist. Cordova's default will be used.`;
         }