fix(pluginHandlers): properly check if path is inside another #1014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The current check for "Is path A inside path B?" relies solely on prefix checking. In general, that is not robust enough.
A real-world example where it fails, is when
Api.createPlatform
is called with adestination
that is outside ofprocess.cwd()
. For example a temp dir during a test. This occurred when refactoring E2E tests.This relies on proper test cleanup as implemented in #1013.
Description
Use
is-path-inside
library.Testing
Api.createPlatform
now works as expectedThe new test calls
copyFile
with the same arguments as Test#006 and Test#007 with the sole difference that the project dir is relative to the current dir.