refactor(lib/run): simplify code to determine install/run target #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When on this PR, it doesn't appear that the CLI properly detects of the emulator is already running and fails to redeploy the app on the Prompt waits for the emulator to start when it's already running. |
|
Thanks for the thorough check @breautek. I'll look into this when I find the time. I converted this to a draft until then. |
If the `lookHarder` option is true and the initial `adb devices` run
returned no devices, `device.list` will kill the adb server and try
again.
Unfortunately `adb devices` contains incorrect information when it is
run too soon after the adb server has been restarted. Consider below
commands being executed with one running emulator:
adb devices && killall adb && adb devices && adb devices
While the first invocation of `adb devices` lists the emulator as
running, the second and third one will list it as offline. This is
especially problematic if code contains a sequence such as:
devs = await device.list(true);
emus = await emulator.list();
In that case the third invocation of `adb devices` occurs in
`emulator.list()` but because of the `killall` it lists all emulators as
offline, causing `emus` to be empty.
This commit tries to work around that issue by explicitly restarting the
adb server after it was killed, and waiting for 100 ms after that. Local
experimentation has shown this to be sufficient in all instances. YMMV
of course.
raphinesse
force-pushed
the
run-refactor
branch
from
01cca69 to
dd6ffd9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1082 +/- ##
==========================================
- Coverage 69.83% 69.69% -0.15%
==========================================
Files 20 20
Lines 1810 1808 -2
==========================================
- Hits 1264 1260 -4
- Misses 546 548 +2
Continue to review full report at Codecov.
|
|
Closing in favor of #1101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change simplifies the code that determines on which target (device or emulator) the app should be installed and run on.
This refactoring was triggered during a bigger refactoring (still WIP) that has the goal of doing something similar to apache/cordova-electron#142 here.
Description
The changes made here should not change the observable behavior of the code beyond changing what is logged to the console. The changes included are:
resolveInstallTargetfromlib/run.runlib/runmoduleresolveInstallTargetto async/awaitresolveInstallTargetThe logic for selecting a install/run target is unchanged. Targets are tried to resolve in this order:
--emulatoroption was not given)--deviceoption was not given)Testing
The unit tests for this module still pass.