feat(Adb): list devices _and_ emulators in one go #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
added a commit
to raphinesse/cordova-android
that referenced
this pull request
Nov 17, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Previously
Adb.devicesreturned either emulators or devices. This change allows one to get a list of devices and emulators in one go. This enables refactors that improve performance & stability.This PR is a dependency of #1101.
Description
Adb.devicesnow returns the IDs of all targets in the statedevicedevice.listandemulator.list_startedimplement the respective filtering (in a simpler manner thanAdb.devicesdid)Testing