Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) feat!: java 11 support #1230

Closed
wants to merge 15 commits into from
Closed

Conversation

breautek
Copy link
Contributor

@breautek breautek commented May 9, 2021

Platforms affected

Android

Motivation and Context

Android Studio 4.2 has been released with Java 11 support

Description

Bumps required Java version from 8 to 11.

Depends on #1228 & #1212

Testing

Native unit tests currently not passing.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [] I've updated the documentation if necessary

@breautek breautek added this to the 10.0.0 milestone May 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #1230 (fef832d) into master (ae4dba2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1230      +/-   ##
==========================================
- Coverage   72.02%   72.00%   -0.02%     
==========================================
  Files          21       21              
  Lines        1698     1697       -1     
==========================================
- Hits         1223     1222       -1     
  Misses        475      475              
Impacted Files Coverage Δ
bin/templates/cordova/lib/check_reqs.js 72.66% <100.00%> (ø)
bin/templates/cordova/lib/env/java.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae4dba2...fef832d. Read the comment docs.

@erisu erisu changed the title (WIP) Feat(breaking): Java 11 support (WIP) feat!: java 11 support Jul 7, 2021
@erisu erisu modified the milestones: 10.0.0, 11.0.0 Jul 13, 2021
@mosabab mosabab mentioned this pull request Nov 30, 2021
5 tasks
@breautek
Copy link
Contributor Author

Closing this PR, as abandoned.

Java 11 JDK is already supported and this includes other changes that is likely not necessary.

@breautek breautek closed this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants